Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

2017-02-07 Thread Michal Hocko
On Tue 07-02-17 18:46:55, vinayak menon wrote: > On Tue, Feb 7, 2017 at 5:47 PM, Michal Hocko wrote: > > On Tue 07-02-17 16:39:15, vinayak menon wrote: [...] > >> Starting to kill at the right time helps in recovering memory at a > >> faster rate than waiting for the reclaim to complete. Yes, we m

Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

2017-02-07 Thread vinayak menon
On Tue, Feb 7, 2017 at 5:47 PM, Michal Hocko wrote: > On Tue 07-02-17 16:39:15, vinayak menon wrote: >> On Tue, Feb 7, 2017 at 1:40 PM, Michal Hocko wrote: >> > On Mon 06-02-17 20:40:10, vinayak menon wrote: >> >> On Mon, Feb 6, 2017 at 6:22 PM, Michal Hocko wrote: > [...] >> >> > It would be al

Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

2017-02-07 Thread Michal Hocko
On Tue 07-02-17 16:39:15, vinayak menon wrote: > On Tue, Feb 7, 2017 at 1:40 PM, Michal Hocko wrote: > > On Mon 06-02-17 20:40:10, vinayak menon wrote: > >> On Mon, Feb 6, 2017 at 6:22 PM, Michal Hocko wrote: [...] > >> > It would be also more than useful to say how much the slab reclaim > >> > r

Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

2017-02-07 Thread vinayak menon
On Tue, Feb 7, 2017 at 1:40 PM, Michal Hocko wrote: > On Mon 06-02-17 20:40:10, vinayak menon wrote: >> On Mon, Feb 6, 2017 at 6:22 PM, Michal Hocko wrote: >> > On Mon 06-02-17 17:54:09, Vinayak Menon wrote: >> >> During global reclaim, the nr_reclaimed passed to vmpressure includes the >> >> pag

Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

2017-02-07 Thread Michal Hocko
On Mon 06-02-17 20:40:10, vinayak menon wrote: > On Mon, Feb 6, 2017 at 6:22 PM, Michal Hocko wrote: > > On Mon 06-02-17 17:54:09, Vinayak Menon wrote: > >> During global reclaim, the nr_reclaimed passed to vmpressure includes the > >> pages reclaimed from slab. But the corresponding scanned slab

Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

2017-02-06 Thread vinayak menon
On Mon, Feb 6, 2017 at 6:22 PM, Michal Hocko wrote: > On Mon 06-02-17 17:54:09, Vinayak Menon wrote: >> During global reclaim, the nr_reclaimed passed to vmpressure includes the >> pages reclaimed from slab. But the corresponding scanned slab pages is >> not passed. This can cause total reclaime

Re: [PATCH 1/2 v4] mm: vmscan: do not pass reclaimed slab to vmpressure

2017-02-06 Thread Michal Hocko
On Mon 06-02-17 17:54:09, Vinayak Menon wrote: > During global reclaim, the nr_reclaimed passed to vmpressure includes the > pages reclaimed from slab. But the corresponding scanned slab pages is > not passed. This can cause total reclaimed pages to be greater than > scanned, causing an unsigned