Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

2013-02-11 Thread Chris Ball
Hi, On Mon, Feb 04 2013, Roger Tseng wrote: > Several new models of readers use different way to select driving > capability(a necessary adjustment along with voltage change). Removing this > from device-independent rtsx_pci_sdmmc module. It will be implemented in > device-depend calls encapsulate

Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

2013-02-05 Thread Dan Carpenter
On Tue, Feb 05, 2013 at 10:51:49AM +0800, Roger Tseng wrote: > Hi Dan, > > Correct. I will prevent this kind of breaking in the future. > Cool. Or if we applied 2/3 first and then 1/3 there would be no breakage? Anyway, it's a bit late to combine them at this point. > However, after our analy

Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

2013-02-04 Thread Roger Tseng
Hi Dan, Correct. I will prevent this kind of breaking in the future. However, after our analysis the breaking of patch 1/3 and 2/3 should not fail old devices. And since Samuel has applied 2/3 and 3/3, it might be better for Chris to apply patch 1/3 and let all this things appear in kernel v3

Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment

2013-02-04 Thread Dan Carpenter
On Mon, Feb 04, 2013 at 03:45:57PM +0800, Roger Tseng wrote: > Several new models of readers use different way to select driving > capability(a necessary adjustment along with voltage change). Removing this > from device-independent rtsx_pci_sdmmc module. It will be implemented in > device-depend c