Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-18 Thread Sagar Dharia
Hi Srini Thank you for the review. On 6/18/2015 3:23 PM, Srinivas Kandagatla wrote: Hi Sagar, On 14/06/15 06:49, Sagar Dharia wrote: SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface) alliance. SLIMbus is a 2-wire implementa

Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-18 Thread Srinivas Kandagatla
Hi Sagar, On 14/06/15 06:49, Sagar Dharia wrote: SLIMbus (Serial Low Power Interchip Media Bus) is a specification developed by MIPI (Mobile Industry Processor Interface) alliance. SLIMbus is a 2-wire implementation, which is used to communicate with peripheral components like audio-codec. SLIMb

Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-17 Thread Sagar Dharia
On 6/17/2015 5:45 AM, Mark Brown wrote: On Tue, Jun 16, 2015 at 09:22:31AM -0600, Sagar Dharia wrote: On 6/15/2015 4:54 AM, Mark Brown wrote: On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote: +void slim_ctrl_add_boarddevs(struct slim_controller *ctrl) +{ Why are these operations s

Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-17 Thread Mark Brown
On Tue, Jun 16, 2015 at 09:22:31AM -0600, Sagar Dharia wrote: > On 6/15/2015 4:54 AM, Mark Brown wrote: > >On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote: > >>+void slim_ctrl_add_boarddevs(struct slim_controller *ctrl) > >>+{ > >Why are these operations split? > Some slaves may cho

Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-16 Thread Sagar Dharia
On 6/15/2015 4:54 AM, Mark Brown wrote: On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote: Thanks for the comments. I will take care of most of the comments from you, and Joe and upload V2 shortly. I will also include a controller driver this time. +void slim_ctrl_add_boarddevs(st

Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-15 Thread Mark Brown
On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote: > +static int slim_compare_eaddr(struct slim_eaddr *a, struct slim_eaddr *b) > +{ > + if (a->manf_id == b->manf_id && a->prod_code == b->prod_code && > + a->dev_index == b->dev_index && > + a-

re: [PATCH 1/3] SLIMbus: Device management on SLIMbus

2015-06-14 Thread Joe Perches
> SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SLIMbus is a 2-wire implementation, which is used to communicate with > peripheral components like audio-codec. Perhaps these trivial style things could be cons