Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Thomas Garnier
On Wed, Jul 26, 2017 at 11:25 AM, Russell King - ARM Linux wrote: > On Wed, Jul 26, 2017 at 07:20:22AM -0700, Thomas Garnier wrote: >> On Wed, Jul 26, 2017 at 5:02 AM, Will Deacon wrote: >> > I looked to see what you've done for x86, but it looks like

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Thomas Garnier
On Wed, Jul 26, 2017 at 11:25 AM, Russell King - ARM Linux wrote: > On Wed, Jul 26, 2017 at 07:20:22AM -0700, Thomas Garnier wrote: >> On Wed, Jul 26, 2017 at 5:02 AM, Will Deacon wrote: >> > I looked to see what you've done for x86, but it looks like you check/clear >> > the flag before the

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Russell King - ARM Linux
On Wed, Jul 26, 2017 at 07:20:22AM -0700, Thomas Garnier wrote: > On Wed, Jul 26, 2017 at 5:02 AM, Will Deacon wrote: > > I looked to see what you've done for x86, but it looks like you check/clear > > the flag before the work pending loop (exit_to_usermode_loop), which > >

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Russell King - ARM Linux
On Wed, Jul 26, 2017 at 07:20:22AM -0700, Thomas Garnier wrote: > On Wed, Jul 26, 2017 at 5:02 AM, Will Deacon wrote: > > I looked to see what you've done for x86, but it looks like you check/clear > > the flag before the work pending loop (exit_to_usermode_loop), which > > subsequently

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Thomas Garnier
On Wed, Jul 26, 2017 at 5:02 AM, Will Deacon wrote: > On Tue, Jul 25, 2017 at 01:01:17PM -0700, Thomas Garnier wrote: >> On Tue, Jul 25, 2017 at 3:38 AM, Russell King - ARM Linux >> wrote: >> > On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Thomas Garnier
On Wed, Jul 26, 2017 at 5:02 AM, Will Deacon wrote: > On Tue, Jul 25, 2017 at 01:01:17PM -0700, Thomas Garnier wrote: >> On Tue, Jul 25, 2017 at 3:38 AM, Russell King - ARM Linux >> wrote: >> > On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote: >> >> On Mon, 2017-07-24 at 10:07

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Will Deacon
On Tue, Jul 25, 2017 at 01:01:17PM -0700, Thomas Garnier wrote: > On Tue, Jul 25, 2017 at 3:38 AM, Russell King - ARM Linux > wrote: > > On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote: > >> On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: > >> > On

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-26 Thread Will Deacon
On Tue, Jul 25, 2017 at 01:01:17PM -0700, Thomas Garnier wrote: > On Tue, Jul 25, 2017 at 3:38 AM, Russell King - ARM Linux > wrote: > > On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote: > >> On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: > >> > On Wed, Jul 19, 2017 at

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-25 Thread Thomas Garnier
On Tue, Jul 25, 2017 at 3:38 AM, Russell King - ARM Linux wrote: > On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote: >> On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: >> > On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier > > >

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-25 Thread Thomas Garnier
On Tue, Jul 25, 2017 at 3:38 AM, Russell King - ARM Linux wrote: > On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote: >> On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: >> > On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier > > > wrote: >> > > >> > > The work pending loop

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-25 Thread Russell King - ARM Linux
On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote: > On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: > > On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier > > wrote: > > > > > > The work pending loop can call set_fs after addr_limit_user_check > > >

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-25 Thread Russell King - ARM Linux
On Tue, Jul 25, 2017 at 01:28:01PM +0300, Leonard Crestez wrote: > On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: > > On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier > > wrote: > > > > > > The work pending loop can call set_fs after addr_limit_user_check > > > removed the _TIF_FSCHECK

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-25 Thread Leonard Crestez
On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: > On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier > wrote: > > > > The work pending loop can call set_fs after addr_limit_user_check > > removed the _TIF_FSCHECK flag. To prevent the infinite loop, move > > the

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-25 Thread Leonard Crestez
On Mon, 2017-07-24 at 10:07 -0700, Thomas Garnier wrote: > On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier > wrote: > > > > The work pending loop can call set_fs after addr_limit_user_check > > removed the _TIF_FSCHECK flag. To prevent the infinite loop, move > > the addr_limit_user_check call

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-24 Thread Thomas Garnier
On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier wrote: > The work pending loop can call set_fs after addr_limit_user_check > removed the _TIF_FSCHECK flag. To prevent the infinite loop, move > the addr_limit_user_check call at the beginning of the loop. > > Fixes:

Re: [PATCH 1/3] arm/syscalls: Move address limit check in loop

2017-07-24 Thread Thomas Garnier
On Wed, Jul 19, 2017 at 10:58 AM, Thomas Garnier wrote: > The work pending loop can call set_fs after addr_limit_user_check > removed the _TIF_FSCHECK flag. To prevent the infinite loop, move > the addr_limit_user_check call at the beginning of the loop. > > Fixes: 73ac5d6a2b6a ("arm/syscalls: