On 26 Feb 2018 00:54, Robert Abel wrote:> Robert Abel (4):
> auxdisplay: charlcd: fix two-line command ^[[LN not marked as
> processed
> auxdisplay: charlcd: name x/y address struct
> auxdisplay: charlcd: fix x/y address commands
> auxdisplay: charlcd: make home command unshift display
The following patch set fixes the x/y coordinate addressing issue I mentioned
earlier
as well as not marking the two-line command sequence as processed resulting in
a confusing
state.
I implemented the logic around using kstrtoul by terminating the substrings
that contain
numbers for each comma
The following patch set fixes the x/y coordinate addressing issue I mentioned
earlier
as well as not marking the two-line command sequence as processed resulting in
a confusing
state.
I implemented the logic around using kstrtoul by terminating the substrings
that contain
numbers for each comma
Hi Andy,
On 15 Feb 2018 11:57, Andy Shevchenko wrote:
> On Thu, Feb 15, 2018 at 1:17 AM, Robert Abel wrote:
>> hex_to_bin look fine to me, although personally I'm not a big fan of its
>> use of tolower.
>
> Let's duplicate then over and over?
I was speaking more generally about performance here
On Thu, Feb 15, 2018 at 1:17 AM, Robert Abel wrote:
> On 13 Feb 2018 14:36, Andy Shevchenko wrote:
>> I understand that we have a huge and hopefully nice library in the
>> kernel, but the question still the same, what prevents a developer or
>> maintainer to look at it from time to time?
>>
>> For
On 13 Feb 2018 14:36, Andy Shevchenko wrote:
> I understand that we have a huge and hopefully nice library in the
> kernel, but the question still the same, what prevents a developer or
> maintainer to look at it from time to time?
>
> For, I dare to say, ages we have hex_to_bin() and hex2bin().
>
On Tue, Feb 13, 2018 at 03:36:45PM +0200, Andy Shevchenko wrote:
> On Sat, Feb 10, 2018 at 11:41 AM, Miguel Ojeda
> wrote:
> > On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau wrote:
> >> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote:
> >>> On Sat, Feb 10, 2018 at 12:50 AM, Robert A
On Sat, Feb 10, 2018 at 11:41 AM, Miguel Ojeda
wrote:
> On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau wrote:
>> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote:
>>> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
>>> > shift ^= 4;
>>> >
On Sat, Feb 10, 2018 at 10:41 AM, Miguel Ojeda
wrote:
> On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau wrote:
>> Hi Miguel,
>>
>> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote:
>>> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
>>> > The graphics command expects 16 hexadeci
On Sat, Feb 10, 2018 at 07:31:54PM +0100, Geert Uytterhoeven wrote:
> The redefinition feature definitely works with hex characters.
> I've used it in the past, cfr. the picture on my Google+ profile ;-)
> https://plus.google.com/u/0/+GeertUytterhoeven
I've used it as well which is why I never not
On Sat, Feb 10, 2018 at 9:58 AM, Miguel Ojeda
wrote:
> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
>> The graphics command expects 16 hexadecimal literals, but would allow
>> characters in range [0-9a-zA-Z] instead of [0-9a-fA-F].
>>
>> Signed-off-by: Robert Abel
Reviewed-by: Geert Uy
On Sat, Feb 10, 2018 at 10:20 AM, Willy Tarreau wrote:
> Hi Miguel,
>
> On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote:
>> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
>> > The graphics command expects 16 hexadecimal literals, but would allow
>> > characters in range [0-9a-
Hi Miguel,
On Sat, Feb 10, 2018 at 09:58:44AM +0100, Miguel Ojeda wrote:
> On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
> > The graphics command expects 16 hexadecimal literals, but would allow
> > characters in range [0-9a-zA-Z] instead of [0-9a-fA-F].
> >
> > Signed-off-by: Robert Abel
On Sat, Feb 10, 2018 at 12:50 AM, Robert Abel wrote:
> The graphics command expects 16 hexadecimal literals, but would allow
> characters in range [0-9a-zA-Z] instead of [0-9a-fA-F].
>
> Signed-off-by: Robert Abel
> ---
> drivers/auxdisplay/charlcd.c | 4 ++--
> 1 file changed, 2 insertions(+),
14 matches
Mail list logo
