Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver

2016-08-16 Thread Stephen Boyd
On 08/16, Neil Armstrong wrote: > On 08/13/2016 03:29 AM, Stephen Boyd wrote: > > On 08/09, Neil Armstrong wrote: > > >> + > >> +static struct clk_hw_onecell_data gxbb_aoclk_onecell_data = { > > > > can this be const? > > It would be awesome, but it will be discarded by of_clk_add_hw_provider :

Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver

2016-08-16 Thread Neil Armstrong
On 08/15/2016 02:08 AM, Paul Gortmaker wrote: > On Tue, Aug 9, 2016 at 5:13 AM, Neil Armstrong > wrote: >> Adds a Clock and Reset controller driver for the Always-On part >> of the Amlogic Meson GXBB SoC. >> >> It exports paired Clocks and Resets lines that will be used by >> peripherals in the A

Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver

2016-08-16 Thread Neil Armstrong
Hi Stephen, On 08/13/2016 03:29 AM, Stephen Boyd wrote: > On 08/09, Neil Armstrong wrote: >> diff --git a/drivers/clk/meson/gxbb-aoclk.c b/drivers/clk/meson/gxbb-aoclk.c >> new file mode 100644 >> index 000..56a9186 >> --- /dev/null >> +++ b/drivers/clk/meson/gxbb-aoclk.c >> @@ -0,0 +1,203 @@

Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver

2016-08-14 Thread Paul Gortmaker
On Tue, Aug 9, 2016 at 5:13 AM, Neil Armstrong wrote: > Adds a Clock and Reset controller driver for the Always-On part > of the Amlogic Meson GXBB SoC. > > It exports paired Clocks and Resets lines that will be used by > peripherals in the Always-On subsystem. [...] > +static const struct of_de

Re: [PATCH 1/3] clk: meson: Add GXBB AO Clock and Reset controller driver

2016-08-12 Thread Stephen Boyd
On 08/09, Neil Armstrong wrote: > diff --git a/drivers/clk/meson/gxbb-aoclk.c b/drivers/clk/meson/gxbb-aoclk.c > new file mode 100644 > index 000..56a9186 > --- /dev/null > +++ b/drivers/clk/meson/gxbb-aoclk.c > @@ -0,0 +1,203 @@ > +/* > + * This file is provided under a dual BSD/GPLv2 license.