Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Rob, On Tue, Dec 5, 2017 at 2:56 PM, Rob Herring wrote: > On Tue, Dec 5, 2017 at 3:09 AM, Geert Uytterhoeven > wrote: >> On Tue, Dec 5, 2017 at 9:57 AM, Geert Uytterhoeven >> wrote: >>> On Mon, Dec 4, 2017 at 10:17 PM, Rob

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Rob, On Tue, Dec 5, 2017 at 2:56 PM, Rob Herring wrote: > On Tue, Dec 5, 2017 at 3:09 AM, Geert Uytterhoeven > wrote: >> On Tue, Dec 5, 2017 at 9:57 AM, Geert Uytterhoeven >> wrote: >>> On Mon, Dec 4, 2017 at 10:17 PM, Rob Herring wrote: On Mon, Dec 04, 2017 at 10:17:47AM +0100,

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Rob Herring
On Tue, Dec 5, 2017 at 3:09 AM, Geert Uytterhoeven wrote: > Hi Rob, > > On Tue, Dec 5, 2017 at 9:57 AM, Geert Uytterhoeven > wrote: >> On Mon, Dec 4, 2017 at 10:17 PM, Rob Herring wrote: >>> On Mon, Dec 04, 2017 at 10:17:47AM +0100,

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Rob Herring
On Tue, Dec 5, 2017 at 3:09 AM, Geert Uytterhoeven wrote: > Hi Rob, > > On Tue, Dec 5, 2017 at 9:57 AM, Geert Uytterhoeven > wrote: >> On Mon, Dec 4, 2017 at 10:17 PM, Rob Herring wrote: >>> On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: On Thu, Nov 30, 2017 at 2:29

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Rob, On Tue, Dec 5, 2017 at 9:57 AM, Geert Uytterhoeven wrote: > On Mon, Dec 4, 2017 at 10:17 PM, Rob Herring wrote: >> On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: >>> On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven >>>

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Rob, On Tue, Dec 5, 2017 at 9:57 AM, Geert Uytterhoeven wrote: > On Mon, Dec 4, 2017 at 10:17 PM, Rob Herring wrote: >> On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: >>> On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven >>> wrote: >>> > Certain EEPROMS have a size

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Ivo, On Mon, Dec 4, 2017 at 11:00 PM, Ivo Sieben wrote: > 2017-12-04 10:17 GMT+01:00 Geert Uytterhoeven : >>> EEPROMs using 9 address bits are common (e.g. M95040, 25AA040/25LC040). >>> Do EEPROMs using 17 or 25 address bits, as mentioned in >>>

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Ivo, On Mon, Dec 4, 2017 at 11:00 PM, Ivo Sieben wrote: > 2017-12-04 10:17 GMT+01:00 Geert Uytterhoeven : >>> EEPROMs using 9 address bits are common (e.g. M95040, 25AA040/25LC040). >>> Do EEPROMs using 17 or 25 address bits, as mentioned in >>> include/linux/spi/eeprom.h, really exist? >>>

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Rob, On Mon, Dec 4, 2017 at 10:17 PM, Rob Herring wrote: > On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven >> wrote: >> > Certain EEPROMS have a size that is larger than the

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-05 Thread Geert Uytterhoeven
Hi Rob, On Mon, Dec 4, 2017 at 10:17 PM, Rob Herring wrote: > On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: >> On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven >> wrote: >> > Certain EEPROMS have a size that is larger than the number of address >> > bytes would allow,

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-04 Thread Ivo Sieben
Hi Geert, My 2 cents: 2017-12-04 10:17 GMT+01:00 Geert Uytterhoeven : >> EEPROMs using 9 address bits are common (e.g. M95040, 25AA040/25LC040). >> Do EEPROMs using 17 or 25 address bits, as mentioned in >> include/linux/spi/eeprom.h, really exist? >> Or should we just

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-04 Thread Ivo Sieben
Hi Geert, My 2 cents: 2017-12-04 10:17 GMT+01:00 Geert Uytterhoeven : >> EEPROMs using 9 address bits are common (e.g. M95040, 25AA040/25LC040). >> Do EEPROMs using 17 or 25 address bits, as mentioned in >> include/linux/spi/eeprom.h, really exist? >> Or should we just limit it to a single odd

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-04 Thread Rob Herring
On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven > wrote: > > Certain EEPROMS have a size that is larger than the number of address > > bytes would allow, and store the MSB of the address in bit 3 of

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-04 Thread Rob Herring
On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven > wrote: > > Certain EEPROMS have a size that is larger than the number of address > > bytes would allow, and store the MSB of the address in bit 3 of the > > instruction

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-04 Thread Geert Uytterhoeven
On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven wrote: > Certain EEPROMS have a size that is larger than the number of address > bytes would allow, and store the MSB of the address in bit 3 of the > instruction byte. > > This can be described in platform data using

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-04 Thread Geert Uytterhoeven
On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven wrote: > Certain EEPROMS have a size that is larger than the number of address > bytes would allow, and store the MSB of the address in bit 3 of the > instruction byte. > > This can be described in platform data using EE_INSTR_BIT3_IS_ADDR, or >