Re: [PATCH 1/3] i2c: tegra: implement slave mode

2015-03-30 Thread Andrey Danin
Hi, Sorry for long delay. And thanks for the quick review. It helped a lot! On 29.01.2015 14:41, Wolfram Sang wrote: Hi, Initialization code is based on NVEC driver. There is a HW bug in AP20 that was also mentioned in kernel sources for Toshiba AC100. Signed-off-by: Andrey Danin Cool,

Re: [PATCH 1/3] i2c: tegra: implement slave mode

2015-01-29 Thread Wolfram Sang
Hi, > Initialization code is based on NVEC driver. > > There is a HW bug in AP20 that was also mentioned in kernel sources > for Toshiba AC100. > > Signed-off-by: Andrey Danin Cool, thanks for the converison. While I usually like to only get the patches which I need to handle, please CC me to

Re: [PATCH 1/3] i2c: tegra: implement slave mode

2015-01-29 Thread Marc Dietrich
Hi Andrey, first, thanks for accepting the challenge once more ;-) The driver depends on I2C_SLAVE now, so you need to add this to Kconfig. The amount of code (and additional overhead) is pretty small, so I think it's ok to always enable it. Otherwise we would need lots of ifdefs. Am Donnersta