On Fri, Jan 10, 2014 at 10:56 AM, Lee Jones wrote:
> On Thu, 09 Jan 2014, Laszlo Papp wrote:
>
>> >> +int max6651_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
>> >> +{
>> >
>> > Probably best to use Regmap instead.
>> >
>> > regmap_i2c_read()
>>
>> >> +int max6651_write_reg(struct i2c_client
On Thu, 09 Jan 2014, Laszlo Papp wrote:
> >> +int max6651_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
> >> +{
> >
> > Probably best to use Regmap instead.
> >
> > regmap_i2c_read()
>
> >> +int max6651_write_reg(struct i2c_client *i2c, u8 reg, u8 value)
> >> +{
> >> +struct max6651_dev
>> +int max6651_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
>> +{
>
> Probably best to use Regmap instead.
>
> regmap_i2c_read()
>> +int max6651_write_reg(struct i2c_client *i2c, u8 reg, u8 value)
>> +{
>> +struct max6651_dev *max6651 = i2c_get_clientdata(i2c);
>> +int ret;
>
> Same
> >> > Can you show me where you are using them?
> >>
> >> Perhaps, I was not while submitting this change, but the upcoming
> >> changes should.
> >
> > Again, this adds confusion. Send your best, cleanest, most up-to-date
> > code, or all you're doing is wasting people's time.
>
> Well, that is
On Thu, Jan 9, 2014 at 11:06 AM, Lee Jones wrote:
>> > Styling i.e nice, neat, easily readable/maintainable code should be
>> > your bread and butter. If styling tires you, perhaps a new career
>> > might be in order. ;)
>>
>> or a new tool to be more professional ...
>
> Patches accepted.
>
>> >>
> > Styling i.e nice, neat, easily readable/maintainable code should be
> > your bread and butter. If styling tires you, perhaps a new career
> > might be in order. ;)
>
> or a new tool to be more professional ...
Patches accepted.
> >> >> +#include
> >> >> +#include
> >> >
> >> > Why is this
On Thu, Jan 9, 2014 at 9:41 AM, Lee Jones wrote:
>> >> +config MFD_MAX6651
>> >> + bool "Maxim Semiconductor MAX6651 Support"
>> >> + depends on I2C=y
>> >> + select MFD_CORE
>> >> + select IRQ_DOMAIN
>> >
>> > Why have you selected IRQ_DOMAIN?
>>
>> Initial consistency with other
> >> +config MFD_MAX6651
> >> + bool "Maxim Semiconductor MAX6651 Support"
> >> + depends on I2C=y
> >> + select MFD_CORE
> >> + select IRQ_DOMAIN
> >
> > Why have you selected IRQ_DOMAIN?
>
> Initial consistency with other corresponding drivers, but I should
> have dropped it once
On Wed, Jan 8, 2014 at 10:39 PM, Lee Jones wrote:
>> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
>> chip includes fan-speed regulators and monitors, GPIO, and alarm.
>>
>> This patch is an initial release of a MAX6650/6651 MFD driver that
>> supports to enable the chip wit
> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
> chip includes fan-speed regulators and monitors, GPIO, and alarm.
>
> This patch is an initial release of a MAX6650/6651 MFD driver that
> supports to enable the chip with its primary I2C bus that will connect
> the hwmon, an
On Tue, Jan 7, 2014 at 2:11 PM, Linus Walleij wrote:
> On Mon, Dec 23, 2013 at 5:08 PM, Laszlo Papp wrote:
>
>> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
>> chip includes fan-speed regulators and monitors, GPIO, and alarm.
>>
>> This patch is an initial release of a MAX
On Mon, Dec 23, 2013 at 5:08 PM, Laszlo Papp wrote:
> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
> chip includes fan-speed regulators and monitors, GPIO, and alarm.
>
> This patch is an initial release of a MAX6650/6651 MFD driver that
> supports to enable the chip with
12 matches
Mail list logo
