Re: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status

2014-07-09 Thread Bjorn Andersson
On Wed, Jul 9, 2014 at 12:59 AM, Linus Walleij wrote: > On Tue, Jul 8, 2014 at 3:26 AM, Bjorn Andersson > wrote: > >> Most status bits, e.g. for GPIO and MPP input, is retrieved by reading >> the interrupt status registers, so this needs to be exposed to clients. >> >> Signed-off-by: Bjorn Anders

Re: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status

2014-07-09 Thread Linus Walleij
On Tue, Jul 8, 2014 at 3:26 AM, Bjorn Andersson wrote: > Most status bits, e.g. for GPIO and MPP input, is retrieved by reading > the interrupt status registers, so this needs to be exposed to clients. > > Signed-off-by: Bjorn Andersson Hm do you mean you read the input *values* from the interr

Re: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status

2014-07-09 Thread Ivan T. Ivanov
On Tue, 2014-07-08 at 16:43 -0700, Bjorn Andersson wrote: > On Tue, Jul 8, 2014 at 4:20 PM, Stephen Boyd wrote: > > On 07/07/14 18:26, Bjorn Andersson wrote: > [...] > > Sad, the header file came back. I guess there isn't a way to put the > > pinctrl driver inside the core mfd driver? Then we w

Re: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status

2014-07-08 Thread Bjorn Andersson
On Tue, Jul 8, 2014 at 4:20 PM, Stephen Boyd wrote: > On 07/07/14 18:26, Bjorn Andersson wrote: >> @@ -65,6 +66,41 @@ struct pm_irq_chip { >> u8 config[0]; >> }; >> >> +int pm8xxx_read_irq_status(int irq) >> +{ >> + struct irq_data *d = irq_get_irq_data(irq); >> +

Re: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status

2014-07-08 Thread Stephen Boyd
On 07/07/14 18:26, Bjorn Andersson wrote: > @@ -65,6 +66,41 @@ struct pm_irq_chip { > u8 config[0]; > }; > > +int pm8xxx_read_irq_status(int irq) > +{ > + struct irq_data *d = irq_get_irq_data(irq); > + struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);