Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache

2014-08-31 Thread Joonsoo Kim
On Wed, Aug 27, 2014 at 06:37:33PM -0500, Christoph Lameter wrote: > One minor nit. Otherwise > > Acked-by: Christoph Lameter > > On Thu, 21 Aug 2014, Joonsoo Kim wrote: > > > @@ -2041,56 +1982,63 @@ static size_t calculate_slab_order(struct > > kmem_cache *cachep, > > return left_over; >

Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache

2014-08-27 Thread Christoph Lameter
One minor nit. Otherwise Acked-by: Christoph Lameter On Thu, 21 Aug 2014, Joonsoo Kim wrote: > @@ -2041,56 +1982,63 @@ static size_t calculate_slab_order(struct kmem_cache > *cachep, > return left_over; > } > > +static int alloc_kmem_cache_cpus(struct kmem_cache *cachep, int entries, >

Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache

2014-08-26 Thread Christoph Lameter
On Tue, 26 Aug 2014, Joonsoo Kim wrote: > > What case? SLUB uses a linked list and therefore does not have these > > storage requirements. > > I misunderstand that you mentioned just memory usage. My *any case* > means memory usage of previous SLAB and SLAB with this percpu alloc > change. Sorry f

Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache

2014-08-25 Thread Joonsoo Kim
On Mon, Aug 25, 2014 at 08:13:58AM -0500, Christoph Lameter wrote: > On Mon, 25 Aug 2014, Joonsoo Kim wrote: > > > On Thu, Aug 21, 2014 at 09:21:30AM -0500, Christoph Lameter wrote: > > > On Thu, 21 Aug 2014, Joonsoo Kim wrote: > > > > > > > So, this patch try to use percpu allocator in SLAB. This

Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache

2014-08-25 Thread Christoph Lameter
On Mon, 25 Aug 2014, Joonsoo Kim wrote: > On Thu, Aug 21, 2014 at 09:21:30AM -0500, Christoph Lameter wrote: > > On Thu, 21 Aug 2014, Joonsoo Kim wrote: > > > > > So, this patch try to use percpu allocator in SLAB. This simplify > > > initialization step in SLAB so that we could maintain SLAB code

Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache

2014-08-25 Thread Joonsoo Kim
On Thu, Aug 21, 2014 at 09:21:30AM -0500, Christoph Lameter wrote: > On Thu, 21 Aug 2014, Joonsoo Kim wrote: > > > So, this patch try to use percpu allocator in SLAB. This simplify > > initialization step in SLAB so that we could maintain SLAB code more > > easily. > > I thought about this a coup

Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache

2014-08-21 Thread Christoph Lameter
On Thu, 21 Aug 2014, Joonsoo Kim wrote: > So, this patch try to use percpu allocator in SLAB. This simplify > initialization step in SLAB so that we could maintain SLAB code more > easily. I thought about this a couple of times but the amount of memory used for the per cpu arrays can be huge. In