Re: [PATCH 1/3] mm: introduce mem_cgroup_put() helper

2018-08-01 Thread Johannes Weiner
On Mon, Jul 30, 2018 at 11:00:58AM -0700, Roman Gushchin wrote: > Introduce the mem_cgroup_put() helper, which helps to eliminate guarding > memcg css release with "#ifdef CONFIG_MEMCG" in multiple places. > > Link: http://lkml.kernel.org/r/20180623000600.5818-2-g...@fb.com > Signed-off-by: Roman

Re: [PATCH 1/3] mm: introduce mem_cgroup_put() helper

2018-07-31 Thread Michal Hocko
On Tue 31-07-18 07:58:00, Shakeel Butt wrote: > On Tue, Jul 31, 2018 at 1:45 AM Michal Hocko wrote: > > > > On Mon 30-07-18 11:00:58, Roman Gushchin wrote: > > > Introduce the mem_cgroup_put() helper, which helps to eliminate guarding > > > memcg css release with "#ifdef CONFIG_MEMCG" in multiple

Re: [PATCH 1/3] mm: introduce mem_cgroup_put() helper

2018-07-31 Thread Shakeel Butt
On Tue, Jul 31, 2018 at 1:45 AM Michal Hocko wrote: > > On Mon 30-07-18 11:00:58, Roman Gushchin wrote: > > Introduce the mem_cgroup_put() helper, which helps to eliminate guarding > > memcg css release with "#ifdef CONFIG_MEMCG" in multiple places. > > Is there any reason for this to be a separat

Re: [PATCH 1/3] mm: introduce mem_cgroup_put() helper

2018-07-31 Thread Michal Hocko
On Mon 30-07-18 11:00:58, Roman Gushchin wrote: > Introduce the mem_cgroup_put() helper, which helps to eliminate guarding > memcg css release with "#ifdef CONFIG_MEMCG" in multiple places. Is there any reason for this to be a separate patch? I usually do not like to add helpers without their user