Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

2018-12-05 Thread Kees Cook
On Wed, Dec 5, 2018 at 7:43 PM Steven Rostedt wrote: > > On Wed, 5 Dec 2018 19:29:11 -0800 > Kees Cook wrote: > > > On Wed, Dec 5, 2018 at 6:29 PM Steven Rostedt wrote: > > > > > > On Wed, 5 Dec 2018 21:26:51 -0500 > > > Steven Rostedt wrote: > > > > > > > On Wed, 5 Dec 2018 17:08:34 -0800 > >

Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

2018-12-05 Thread Steven Rostedt
On Wed, 5 Dec 2018 19:29:11 -0800 Kees Cook wrote: > On Wed, Dec 5, 2018 at 6:29 PM Steven Rostedt wrote: > > > > On Wed, 5 Dec 2018 21:26:51 -0500 > > Steven Rostedt wrote: > > > > > On Wed, 5 Dec 2018 17:08:34 -0800 > > > Kees Cook wrote: > > > > > > > > I'll Ack the Makefile > > > cha

Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

2018-12-05 Thread Kees Cook
On Wed, Dec 5, 2018 at 6:29 PM Steven Rostedt wrote: > > On Wed, 5 Dec 2018 21:26:51 -0500 > Steven Rostedt wrote: > > > On Wed, 5 Dec 2018 17:08:34 -0800 > > Kees Cook wrote: > > > > > I'll Ack the Makefile > > change in the tracing directory, but the rest belongs to others. Okay, I wasn't sur

Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

2018-12-05 Thread Steven Rostedt
On Wed, 5 Dec 2018 21:26:51 -0500 Steven Rostedt wrote: > On Wed, 5 Dec 2018 17:08:34 -0800 > Kees Cook wrote: > > I'll Ack the Makefile > change in the tracing directory, but the rest belongs to others. > I see I already acked that patch. BTW, when sending a patch series, you really need a

Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

2018-12-05 Thread Steven Rostedt
On Wed, 5 Dec 2018 17:08:34 -0800 Kees Cook wrote: > > diff --git a/kernel/stackleak.c b/kernel/stackleak.c > > index e42892926244..5de3bf596dd7 100644 > > --- a/kernel/stackleak.c > > +++ b/kernel/stackleak.c > > @@ -102,7 +102,7 @@ asmlinkage void stackleak_erase(void) > > current->lowe

Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

2018-12-05 Thread Kees Cook
On Fri, Nov 30, 2018 at 7:09 AM Anders Roxell wrote: > > Function graph tracing recurses into itself when stackleak is enabled, > causing the ftrace graph selftest to run for up to 90 seconds and > trigger the softlockup watchdog. > > Breakpoint 2, ftrace_graph_caller () at > ../arch/arm64/kernel

Re: [PATCH 1/3] stackleak: mark stackleak_track_stack() as notrace

2018-11-30 Thread Steven Rostedt
On Fri, 30 Nov 2018 16:08:59 +0100 Anders Roxell wrote: > Function graph tracing recurses into itself when stackleak is enabled, > causing the ftrace graph selftest to run for up to 90 seconds and > trigger the softlockup watchdog. > > Breakpoint 2, ftrace_graph_caller () at > ../arch/arm64/ker