Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-23 Thread kongxinwei
On 03/23/2015 12:46 PM, Leo Yan wrote: On Fri, Mar 20, 2015 at 03:55:27PM +, Mark Rutland wrote: That may be the case in the code as it stands today, but per the binding the trip points are the temperatures at which an action is to be taken. The thermal-zone has poilling-delay and polling-

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-22 Thread Leo Yan
On Fri, Mar 20, 2015 at 03:55:27PM +, Mark Rutland wrote: > > > That may be the case in the code as it stands today, but per the binding > > > the trip points are the temperatures at which an action is to be taken. > > > > > > The thermal-zone has poilling-delay and polling-delay-passive, but

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-20 Thread Mark Rutland
> > That may be the case in the code as it stands today, but per the binding > > the trip points are the temperatures at which an action is to be taken. > > > > The thermal-zone has poilling-delay and polling-delay-passive, but > > there's no reason you couldn't also use the interrupt to handle th

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-20 Thread Xinwei Kong
On 2015年03月20日 19:24, Mark Rutland wrote: + ret = of_property_read_u32(np, "hisilicon,tsensor-thres-temp", + &sensor->thres_temp); + if (ret) { + dev_err(&pdev->dev, "failed to get thres value %d: %d\n", + index, re

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-20 Thread Leo Yan
On Fri, Mar 20, 2015 at 11:24:14AM +, Mark Rutland wrote: > > > > + ret = of_property_read_u32(np, "hisilicon,tsensor-thres-temp", > > > > + &sensor->thres_temp); > > > > + if (ret) { > > > > + dev_err(&pdev->dev, "failed to get thres v

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-20 Thread Mark Rutland
> > > + ret = of_property_read_u32(np, "hisilicon,tsensor-thres-temp", > > > + &sensor->thres_temp); > > > + if (ret) { > > > + dev_err(&pdev->dev, "failed to get thres value %d: %d\n", > > > + index, ret); > > > +

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-20 Thread kongxinwei
在 2015/3/19 22:17, Mark Rutland 写道: > On Thu, Mar 19, 2015 at 07:57:27AM +, kongxinwei wrote: >> This patch adds the support for hisilicon thermal sensor, within >> hisilicon SoC. there will register sensors for thermal framework >> and use device tree to bind cooling device. >> >> Signed-off

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-19 Thread Leo Yan
hi Mark, Thanks for reviewing, pls see below questions. On Thu, Mar 19, 2015 at 02:17:53PM +, Mark Rutland wrote: > On Thu, Mar 19, 2015 at 07:57:27AM +, kongxinwei wrote: > > This patch adds the support for hisilicon thermal sensor, within > > hisilicon SoC. there will register sensors f

Re: [PATCH 1/3] thermal: hisilicon: add new hisilicon thermal sensor driver

2015-03-19 Thread Mark Rutland
On Thu, Mar 19, 2015 at 07:57:27AM +, kongxinwei wrote: > This patch adds the support for hisilicon thermal sensor, within > hisilicon SoC. there will register sensors for thermal framework > and use device tree to bind cooling device. > > Signed-off-by: Leo Yan > Signed-off-by: kongxinwei >