Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Paul E. McKenney
On Sun, Dec 14, 2014 at 01:25:56PM -0500, Steven Rostedt wrote: > On Sun, 14 Dec 2014 10:18:35 -0800 > "Paul E. McKenney" wrote: > > > > With your feed back, and because I would like this to go into 3.19, I > > > would like to keep the current patch as is (with the read_mostly > > > update, which

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Steven Rostedt
On Sun, 14 Dec 2014 10:18:35 -0800 "Paul E. McKenney" wrote: > > With your feed back, and because I would like this to go into 3.19, I > > would like to keep the current patch as is (with the read_mostly > > update, which I'm currently testing). We can always change it later > > after call_rcu()

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Paul E. McKenney
On Sun, Dec 14, 2014 at 01:15:38PM -0500, Steven Rostedt wrote: > On Sun, 14 Dec 2014 10:08:54 -0800 > "Paul E. McKenney" wrote: > > > On Sun, Dec 14, 2014 at 11:53:32AM -0500, Steven Rostedt wrote: > > > On Sun, 14 Dec 2014 11:41:05 -0500 > > > Steven Rostedt wrote: > > > > > > > From: "Steven

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Steven Rostedt
On Sun, 14 Dec 2014 10:08:54 -0800 "Paul E. McKenney" wrote: > On Sun, Dec 14, 2014 at 11:53:32AM -0500, Steven Rostedt wrote: > > On Sun, 14 Dec 2014 11:41:05 -0500 > > Steven Rostedt wrote: > > > > > From: "Steven Rostedt (Red Hat)" > > > > > > In order to move enabling of trace events to j

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Paul E. McKenney
On Sun, Dec 14, 2014 at 12:44:31PM -0500, Steven Rostedt wrote: > On Sun, 14 Dec 2014 17:29:28 + (UTC) > Mathieu Desnoyers wrote: > > > Given that your reason for having this RCU-specific logic in tracepoint.c > > rather than within call_rcu*() is not slowing down a fast-path, how about > > c

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Paul E. McKenney
On Sun, Dec 14, 2014 at 11:53:32AM -0500, Steven Rostedt wrote: > On Sun, 14 Dec 2014 11:41:05 -0500 > Steven Rostedt wrote: > > > From: "Steven Rostedt (Red Hat)" > > > > In order to move enabling of trace events to just after mm_init(), the > > tracepoint enable code can not use call_rcu_sche

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Steven Rostedt
On Sun, 14 Dec 2014 17:29:28 + (UTC) Mathieu Desnoyers wrote: > Given that your reason for having this RCU-specific logic in tracepoint.c > rather than within call_rcu*() is not slowing down a fast-path, how about > creating a new call_rcu_early() and call_rcu_sched_early() which can be > cal

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Mathieu Desnoyers
cKenney" > > Sent: Sunday, December 14, 2014 12:21:36 PM > Subject: Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before > early_initcall() > > On Sun, 14 Dec 2014 12:14:57 -0500 > Steven Rostedt wrote: > > > If IRQ setup, or other core pieces of code can

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Steven Rostedt
On Sun, 14 Dec 2014 12:14:57 -0500 Steven Rostedt wrote: > If IRQ setup, or other core pieces of code can use this, then I would > agree that rcu should be changed. But until then, I rather not add > another conditional to the core RCU code. Also, call_rcu*() is called from several hot paths. Th

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Steven Rostedt
On Sun, 14 Dec 2014 17:05:49 + (UTC) Mathieu Desnoyers wrote: > > #ifdef CONFIG_MODULES > > /* > > * Tracepoint module list mutex protects the local module list. > > @@ -76,7 +85,16 @@ static inline void release_probes(struct tracepoint_func > > *old) > > if (old) { > > s

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Mathieu Desnoyers
- Original Message - > From: "Steven Rostedt" > To: linux-kernel@vger.kernel.org > Cc: "Linus Torvalds" , "Ingo Molnar" > , "Andrew Morton" > , "Thomas Gleixner" , "Mathieu > Desnoyers" > , "Paul E. McKenney" > > Sent: Sunday, December 14, 2014 11:41:05 AM > Subject: [PATCH 1/3] tracep

Re: [PATCH 1/3] tracepoints: Do not use call_rcu_sched() before early_initcall()

2014-12-14 Thread Steven Rostedt
On Sun, 14 Dec 2014 11:41:05 -0500 Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > In order to move enabling of trace events to just after mm_init(), the > tracepoint enable code can not use call_rcu_sched() because rcu isn't > even initialized yet. Since this can only happen befo