Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-15 Thread Jan Beulich
>>> On 10.10.12 at 12:45, Matt Fleming wrote: > On Thu, 2012-10-04 at 11:01 +0100, Jan Beulich wrote: >> >>> On 04.10.12 at 11:18, Matt Fleming wrote: >> > On Thu, 2012-10-04 at 07:32 +0100, Jan Beulich wrote: >> >> Btw., once this set of yours is in - will I need to resubmit the >> >> time handl

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-10 Thread Matt Fleming
On Thu, 2012-10-04 at 11:01 +0100, Jan Beulich wrote: > >>> On 04.10.12 at 11:18, Matt Fleming wrote: > > On Thu, 2012-10-04 at 07:32 +0100, Jan Beulich wrote: > >> Btw., once this set of yours is in - will I need to resubmit the > >> time handling patch that actually triggered this work, or will

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-07 Thread Jan Beulich
>>> "H. Peter Anvin" 10/07/12 12:27 PM >>> >Actually, no, because we may need to double-map in the low address space per >discussion at LPC. Now this I don't follow (due to lack of context), but it would of course be relevant for determining the need eventual further adjustments to the patch we'

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-07 Thread H. Peter Anvin
Actually, no, because we may need to double-map in the low address space per discussion at LPC. Jan Beulich wrote: "H. Peter Anvin" 10/05/12 6:28 PM >>> >>On 10/04/2012 11:39 PM, Jan Beulich wrote: We should have the check, but at least for Linux support we require P <= V-2

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-07 Thread Jan Beulich
>>> "H. Peter Anvin" 10/05/12 6:28 PM >>> >On 10/04/2012 11:39 PM, Jan Beulich wrote: >>> >>> We should have the check, but at least for Linux support we require >>> P <= V-2. >> >> Not really imo - P <= V - 1 should be sufficient here, as all that is >> necessary is that the result represents a 1

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-05 Thread H. Peter Anvin
On 10/04/2012 11:39 PM, Jan Beulich wrote: We should have the check, but at least for Linux support we require P <= V-2. Not really imo - P <= V - 1 should be sufficient here, as all that is necessary is that the result represents a 1:1 mapping. Specifically, there's no constraint to the virtu

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-05 Thread Jan Beulich
>>> On 05.10.12 at 08:48, Matt Fleming wrote: > On Fri, 2012-10-05 at 07:39 +0100, Jan Beulich wrote: >> >>> On 04.10.12 at 23:08, "H. Peter Anvin" wrote: >> > On 10/03/2012 06:31 AM, Jan Beulich wrote: >> > Matt Fleming 10/03/12 2:59 PM >>> >> >>> +static int insert_identity_mapping(resourc

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-04 Thread Matt Fleming
On Fri, 2012-10-05 at 07:39 +0100, Jan Beulich wrote: > >>> On 04.10.12 at 23:08, "H. Peter Anvin" wrote: > > On 10/03/2012 06:31 AM, Jan Beulich wrote: > > Matt Fleming 10/03/12 2:59 PM >>> > >>> +static int insert_identity_mapping(resource_size_t paddr, unsigned long > > vaddr, > >>> +

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-04 Thread Jan Beulich
>>> On 04.10.12 at 23:08, "H. Peter Anvin" wrote: > On 10/03/2012 06:31 AM, Jan Beulich wrote: > Matt Fleming 10/03/12 2:59 PM >>> >>> +static int insert_identity_mapping(resource_size_t paddr, unsigned long > vaddr, >>> +unsigned long size) >>> +{ >>> +unsigned long

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-04 Thread H. Peter Anvin
On 10/03/2012 06:31 AM, Jan Beulich wrote: Matt Fleming 10/03/12 2:59 PM >>> +static int insert_identity_mapping(resource_size_t paddr, unsigned long vaddr, +unsigned long size) +{ +unsigned long end = vaddr + size; +unsigned long next; +pgd_t *vpgd, *ppgd; + +#i

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-04 Thread Jan Beulich
>>> On 04.10.12 at 11:18, Matt Fleming wrote: > On Thu, 2012-10-04 at 07:32 +0100, Jan Beulich wrote: >> Btw., once this set of yours is in - will I need to resubmit the >> time handling patch that actually triggered this work, or will >> you just reinstate it without further action on my part? >

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-04 Thread Matt Fleming
On Thu, 2012-10-04 at 07:32 +0100, Jan Beulich wrote: > >>> On 03.10.12 at 16:03, Matt Fleming wrote: > > On Wed, 2012-10-03 at 14:31 +0100, Jan Beulich wrote: > >> >>> Matt Fleming 10/03/12 2:59 PM >>> > >> >@@ -163,6 +258,10 @@ static void __iomem > >> >*__ioremap_caller(resource_size_t phys_a

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-03 Thread Jan Beulich
>>> On 03.10.12 at 16:03, Matt Fleming wrote: > On Wed, 2012-10-03 at 14:31 +0100, Jan Beulich wrote: >> >>> Matt Fleming 10/03/12 2:59 PM >>> >> >@@ -163,6 +258,10 @@ static void __iomem *__ioremap_caller(resource_size_t >> >phys_addr, >> >ret_addr = (void __iomem *) (vaddr + offset); >> >

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-03 Thread Matt Fleming
On Wed, 2012-10-03 at 14:31 +0100, Jan Beulich wrote: > >>> Matt Fleming 10/03/12 2:59 PM >>> > >+static int insert_identity_mapping(resource_size_t paddr, unsigned long > >vaddr, > >+unsigned long size) > >+{ > >+unsigned long end = vaddr + size; > >+unsigned long nex

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-03 Thread Jan Beulich
>>> Matt Fleming 10/03/12 2:59 PM >>> >+static int insert_identity_mapping(resource_size_t paddr, unsigned long vaddr, >+unsigned long size) >+{ >+unsigned long end = vaddr + size; >+unsigned long next; >+pgd_t *vpgd, *ppgd; >+ >+#ifdef CONFIG_X86_32 >+ppgd = in