Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-30 Thread Linus Walleij
On Thu, Aug 29, 2013 at 11:36 AM, Sonic Zhang wrote: > On Thu, Aug 29, 2013 at 4:19 PM, Linus Walleij > wrote: >> So splitting each block into a separate pin control device is definately >> one way to skin the cat. >> >> The ux500 would then have 9 pin controller instances (after a >> big fat

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-30 Thread Linus Walleij
On Thu, Aug 29, 2013 at 11:31 AM, Sonic Zhang wrote: > On Thu, Aug 29, 2013 at 4:12 PM, Linus Walleij > wrote: >> This is similar to the situation in the pinctrl-nomadik.c driver, >> where the pinctrl portions wait for the GPIO devices to instantiate >> before proceeding to probe "on top" of

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-30 Thread Linus Walleij
On Thu, Aug 29, 2013 at 11:31 AM, Sonic Zhang sonic@gmail.com wrote: On Thu, Aug 29, 2013 at 4:12 PM, Linus Walleij linus.wall...@linaro.org wrote: This is similar to the situation in the pinctrl-nomadik.c driver, where the pinctrl portions wait for the GPIO devices to instantiate

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-30 Thread Linus Walleij
On Thu, Aug 29, 2013 at 11:36 AM, Sonic Zhang sonic@gmail.com wrote: On Thu, Aug 29, 2013 at 4:19 PM, Linus Walleij linus.wall...@linaro.org wrote: So splitting each block into a separate pin control device is definately one way to skin the cat. The ux500 would then have 9 pin

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Linus, On Thu, Aug 29, 2013 at 4:19 PM, Linus Walleij wrote: > On Thu, Aug 22, 2013 at 10:48 PM, Stephen Warren > wrote: >> On 08/22/2013 01:07 AM, Sonic Zhang wrote: >>> >>> There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function >>> pinmux_enable_setting() in current pinctrl

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Linus, On Thu, Aug 29, 2013 at 4:12 PM, Linus Walleij wrote: > On Thu, Aug 22, 2013 at 9:07 AM, Sonic Zhang wrote: > >> There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function >> pinmux_enable_setting() in current pinctrl framework assumes the >> function mux setting of one peripheral

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Stephen, On Wed, Aug 28, 2013 at 10:23 PM, Stephen Warren wrote: > On 08/27/2013 09:56 PM, Sonic Zhang wrote: >> Hi Stephen, >> >> On Wed, Aug 28, 2013 at 5:39 AM, Stephen Warren >> wrote: >>> On 08/27/2013 03:30 AM, Sonic Zhang wrote: Hi Stephen, On Fri, Aug 23, 2013 at 4:48

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Linus, On Thu, Aug 29, 2013 at 4:02 PM, Linus Walleij wrote: > On Wed, Aug 21, 2013 at 8:30 AM, Sonic Zhang wrote: > >> From: Sonic Zhang >> >> The new ADI GPIO2 controller was introduced since the BF548 and BF60x >> processors. It differs a lot from the old one on BF5xx processors. So, >>

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Thu, Aug 22, 2013 at 10:48 PM, Stephen Warren wrote: > On 08/22/2013 01:07 AM, Sonic Zhang wrote: >> >> There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function >> pinmux_enable_setting() in current pinctrl framework assumes the >> function mux setting of one peripheral pin group is

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Thu, Aug 22, 2013 at 9:07 AM, Sonic Zhang wrote: > There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function > pinmux_enable_setting() in current pinctrl framework assumes the > function mux setting of one peripheral pin group is configured in one > pinctrl device. But, the function mux

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Thu, Aug 22, 2013 at 9:07 AM, Sonic Zhang wrote: > Is it possible that 2 and more pinctrl devices are on the same SoC? Or > do we always assume there is only one pinctrl device on one SoC? It is possible to have N pinctrl devices on the same SoC, not to mention the whole system. The

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Wed, Aug 21, 2013 at 8:30 AM, Sonic Zhang wrote: > From: Sonic Zhang > > The new ADI GPIO2 controller was introduced since the BF548 and BF60x > processors. It differs a lot from the old one on BF5xx processors. So, > create a pinctrl driver under the pinctrl framework. (...) The v3 is a

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Wed, Aug 21, 2013 at 8:30 AM, Sonic Zhang sonic@gmail.com wrote: From: Sonic Zhang sonic.zh...@analog.com The new ADI GPIO2 controller was introduced since the BF548 and BF60x processors. It differs a lot from the old one on BF5xx processors. So, create a pinctrl driver under the

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Thu, Aug 22, 2013 at 9:07 AM, Sonic Zhang sonic@gmail.com wrote: Is it possible that 2 and more pinctrl devices are on the same SoC? Or do we always assume there is only one pinctrl device on one SoC? It is possible to have N pinctrl devices on the same SoC, not to mention the whole

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Thu, Aug 22, 2013 at 9:07 AM, Sonic Zhang sonic@gmail.com wrote: There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function pinmux_enable_setting() in current pinctrl framework assumes the function mux setting of one peripheral pin group is configured in one pinctrl device. But, the

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Linus Walleij
On Thu, Aug 22, 2013 at 10:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/22/2013 01:07 AM, Sonic Zhang wrote: There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function pinmux_enable_setting() in current pinctrl framework assumes the function mux setting of one peripheral pin

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Linus, On Thu, Aug 29, 2013 at 4:02 PM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Aug 21, 2013 at 8:30 AM, Sonic Zhang sonic@gmail.com wrote: From: Sonic Zhang sonic.zh...@analog.com The new ADI GPIO2 controller was introduced since the BF548 and BF60x processors. It

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Stephen, On Wed, Aug 28, 2013 at 10:23 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2013 09:56 PM, Sonic Zhang wrote: Hi Stephen, On Wed, Aug 28, 2013 at 5:39 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2013 03:30 AM, Sonic Zhang wrote: Hi Stephen, On Fri,

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Linus, On Thu, Aug 29, 2013 at 4:12 PM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Aug 22, 2013 at 9:07 AM, Sonic Zhang sonic@gmail.com wrote: There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function pinmux_enable_setting() in current pinctrl framework assumes the

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-29 Thread Sonic Zhang
Hi Linus, On Thu, Aug 29, 2013 at 4:19 PM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, Aug 22, 2013 at 10:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/22/2013 01:07 AM, Sonic Zhang wrote: There are 6 to 9 GPIO HW blocks in one Blackfin SoC. Function

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-28 Thread Stephen Warren
On 08/27/2013 09:56 PM, Sonic Zhang wrote: > Hi Stephen, > > On Wed, Aug 28, 2013 at 5:39 AM, Stephen Warren wrote: >> On 08/27/2013 03:30 AM, Sonic Zhang wrote: >>> Hi Stephen, >>> >>> On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren >>> wrote: On 08/22/2013 01:07 AM, Sonic Zhang wrote:

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-28 Thread Stephen Warren
On 08/27/2013 09:56 PM, Sonic Zhang wrote: Hi Stephen, On Wed, Aug 28, 2013 at 5:39 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2013 03:30 AM, Sonic Zhang wrote: Hi Stephen, On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/22/2013 01:07 AM,

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-27 Thread Sonic Zhang
Hi Stephen, On Wed, Aug 28, 2013 at 5:39 AM, Stephen Warren wrote: > On 08/27/2013 03:30 AM, Sonic Zhang wrote: >> Hi Stephen, >> >> On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren >> wrote: >>> On 08/22/2013 01:07 AM, Sonic Zhang wrote: Hi Stephen, On Thu, Aug 22, 2013 at 2:45

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-27 Thread Stephen Warren
On 08/27/2013 03:30 AM, Sonic Zhang wrote: > Hi Stephen, > > On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren wrote: >> On 08/22/2013 01:07 AM, Sonic Zhang wrote: >>> Hi Stephen, >>> >>> On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren >>> wrote: On 08/21/2013 12:30 AM, Sonic Zhang wrote:

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-27 Thread Sonic Zhang
Hi Stephen, On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren wrote: > On 08/22/2013 01:07 AM, Sonic Zhang wrote: >> Hi Stephen, >> >> On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren >> wrote: >>> On 08/21/2013 12:30 AM, Sonic Zhang wrote: From: Sonic Zhang The new ADI GPIO2

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-27 Thread Sonic Zhang
Hi Stephen, On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/22/2013 01:07 AM, Sonic Zhang wrote: Hi Stephen, On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/21/2013 12:30 AM, Sonic Zhang wrote: From: Sonic Zhang

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-27 Thread Stephen Warren
On 08/27/2013 03:30 AM, Sonic Zhang wrote: Hi Stephen, On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/22/2013 01:07 AM, Sonic Zhang wrote: Hi Stephen, On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/21/2013 12:30 AM,

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-27 Thread Sonic Zhang
Hi Stephen, On Wed, Aug 28, 2013 at 5:39 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/27/2013 03:30 AM, Sonic Zhang wrote: Hi Stephen, On Fri, Aug 23, 2013 at 4:48 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/22/2013 01:07 AM, Sonic Zhang wrote: Hi Stephen, On Thu, Aug

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-22 Thread Stephen Warren
On 08/22/2013 01:07 AM, Sonic Zhang wrote: > Hi Stephen, > > On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren wrote: >> On 08/21/2013 12:30 AM, Sonic Zhang wrote: >>> From: Sonic Zhang >>> >>> The new ADI GPIO2 controller was introduced since the BF548 and BF60x >>> processors. It differs a lot

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-22 Thread Sonic Zhang
Hi Stephen, On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren wrote: > On 08/21/2013 12:30 AM, Sonic Zhang wrote: >> From: Sonic Zhang >> >> The new ADI GPIO2 controller was introduced since the BF548 and BF60x >> processors. It differs a lot from the old one on BF5xx processors. So, >> create a

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-22 Thread Sonic Zhang
Hi Stephen, On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/21/2013 12:30 AM, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com The new ADI GPIO2 controller was introduced since the BF548 and BF60x processors. It differs a lot from the old one on

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-22 Thread Stephen Warren
On 08/22/2013 01:07 AM, Sonic Zhang wrote: Hi Stephen, On Thu, Aug 22, 2013 at 2:45 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 08/21/2013 12:30 AM, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com The new ADI GPIO2 controller was introduced since the BF548 and BF60x

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-21 Thread Stephen Warren
On 08/21/2013 12:30 AM, Sonic Zhang wrote: > From: Sonic Zhang > > The new ADI GPIO2 controller was introduced since the BF548 and BF60x > processors. It differs a lot from the old one on BF5xx processors. So, > create a pinctrl driver under the pinctrl framework. > drivers/pinctrl/Kconfig

Re: [PATCH 1/3 v3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x.

2013-08-21 Thread Stephen Warren
On 08/21/2013 12:30 AM, Sonic Zhang wrote: From: Sonic Zhang sonic.zh...@analog.com The new ADI GPIO2 controller was introduced since the BF548 and BF60x processors. It differs a lot from the old one on BF5xx processors. So, create a pinctrl driver under the pinctrl framework.