Re: [PATCH 1/3 v5] add a new ima hook and policy to measure the cmdline

> > > +{ > > > + > > > + if (action & IMA_MEASURE) > > > + ret = ima_store_template(entry, violation, NULL, buf, pcr); > > > + > > > + if (action & IMA_AUDIT) > > > + ima_audit_measurement(iint, event_data.filename); > > > > The cover letter and patch description s

Re: [PATCH 1/3 v5] add a new ima hook and policy to measure the cmdline

On Mon, May 13, 2019 at 9:56 AM Mimi Zohar wrote: > > On Fri, 2019-05-10 at 15:37 -0700, Prakhar Srivastava wrote: > > > +/* > > + * process_buffer_measurement - Measure the buffer passed to ima log. > > "passed to ima log" is unnecessary. > > > + * (Instead of using the file hash use the buffer h

Re: [PATCH 1/3 v5] add a new ima hook and policy to measure the cmdline

On Fri, 2019-05-10 at 15:37 -0700, Prakhar Srivastava wrote: > +/* > + * process_buffer_measurement - Measure the buffer passed to ima log. "passed to ima log" is unnecessary. > + * (Instead of using the file hash use the buffer hash). This comment, if needed, belongs in the text description ar