Re: [PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Chris Chiu
On Thu, Jan 7, 2021 at 10:28 PM Mark Brown wrote: > > On Thu, Jan 07, 2021 at 05:06:22PM +0800, Chris Chiu wrote: > > > +static const struct acpi_gpio_mapping *cht_rt5645_gpios; > > + > > You're adding a read only static variable with no way to set it. This > doesn't actually do anything? > This

Re: [PATCH 1/4] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2021-01-07 Thread Mark Brown
On Thu, Jan 07, 2021 at 05:06:22PM +0800, Chris Chiu wrote: > +static const struct acpi_gpio_mapping *cht_rt5645_gpios; > + You're adding a read only static variable with no way to set it. This doesn't actually do anything? > @@ -3780,7 +3782,6 @@ static const struct dmi_system_id dmi_platform_