Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-31 Thread Takashi Iwai
At Thu, 31 Jan 2013 17:48:34 +0800, Ming Lei wrote: > (snip) > > +/* called from request_firmware() and request_firmware_work_func() */ > > +static int > > +_request_firmware(const struct firmware **firmware_p, const char *name, > > + struct device *device, bool uevent, bool nowait

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-31 Thread Ming Lei
On Wed, Jan 30, 2013 at 6:35 PM, Takashi Iwai wrote: > Since 3.7 kernel, the firmware loader can read the firmware files > directly, and the traditional user-mode helper is invoked only as a > fallback. This seems working pretty well, and the next step would be > to reduce the redundant user-mode

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 19:48:15 +0800, Ming Lei wrote: > > On Wed, Jan 30, 2013 at 7:08 PM, Takashi Iwai wrote: > > At Wed, 30 Jan 2013 11:53:14 +0100, > > Takashi Iwai wrote: > >> > >> At Wed, 30 Jan 2013 18:50:05 +0800, > >> Ming Lei wrote: > >> > > >> > On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iw

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Ming Lei
On Wed, Jan 30, 2013 at 7:08 PM, Takashi Iwai wrote: > At Wed, 30 Jan 2013 11:53:14 +0100, > Takashi Iwai wrote: >> >> At Wed, 30 Jan 2013 18:50:05 +0800, >> Ming Lei wrote: >> > >> > On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iwai wrote: >> > > >> > > But it's supposed to be cached, no? >> > >> >

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 11:53:14 +0100, Takashi Iwai wrote: > > At Wed, 30 Jan 2013 18:50:05 +0800, > Ming Lei wrote: > > > > On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iwai wrote: > > > > > > But it's supposed to be cached, no? > > > > Generally it will be cached, but some crazy devices might come a

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Ming Lei
On Wed, Jan 30, 2013 at 6:53 PM, Takashi Iwai wrote: > At Wed, 30 Jan 2013 18:50:05 +0800, > Ming Lei wrote: >> >> On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iwai wrote: >> > >> > But it's supposed to be cached, no? >> >> Generally it will be cached, but some crazy devices might come as new >> devi

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 18:50:05 +0800, Ming Lei wrote: > > On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iwai wrote: > > > > But it's supposed to be cached, no? > > Generally it will be cached, but some crazy devices might come as new > device during resume, so we still need to handle the situation. In

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Ming Lei
On Wed, Jan 30, 2013 at 6:31 PM, Takashi Iwai wrote: > > But it's supposed to be cached, no? Generally it will be cached, but some crazy devices might come as new device during resume, so we still need to handle the situation. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Takashi Iwai
At Wed, 30 Jan 2013 18:25:20 +0800, Ming Lei wrote: > > On Wed, Jan 30, 2013 at 3:17 PM, Takashi Iwai wrote: > >> The above usermodehelper_read_lock thing may be a functional change, > >> and looks not what you claimed in commit log, :-). The lock is currently > >> held in > >> direct loading ca

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-30 Thread Ming Lei
On Wed, Jan 30, 2013 at 3:17 PM, Takashi Iwai wrote: >> The above usermodehelper_read_lock thing may be a functional change, >> and looks not what you claimed in commit log, :-). The lock is currently >> held in >> direct loading case, but your patch change the rule. Without holding the >> lock,

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-29 Thread Takashi Iwai
At Wed, 30 Jan 2013 11:37:30 +0800, Ming Lei wrote: > > On Tue, Jan 29, 2013 at 10:46 PM, Takashi Iwai wrote: > > Since 3.7 kernel, the firmware loader can read the firmware files > > directly, and the traditional user-mode helper is invoked only as a > > fallback. This seems working pretty well

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-29 Thread Ming Lei
On Tue, Jan 29, 2013 at 10:46 PM, Takashi Iwai wrote: > Since 3.7 kernel, the firmware loader can read the firmware files > directly, and the traditional user-mode helper is invoked only as a > fallback. This seems working pretty well, and the next step would be > to reduce the redundant user-mod

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-29 Thread Takashi Iwai
At Tue, 29 Jan 2013 18:24:04 +0800, Ming Lei wrote: > > Hi Takashi, > > On Sat, Jan 26, 2013 at 12:05 AM, Takashi Iwai wrote: > > Since 3.7 kernel, the firmware loader can read the firmware files > > directly, and the traditional user-mode helper is invoked only as a > > fallback. This seems wo

Re: [PATCH 1/4] firmware: Refactoring for splitting user-mode helper code

2013-01-29 Thread Ming Lei
Hi Takashi, On Sat, Jan 26, 2013 at 12:05 AM, Takashi Iwai wrote: > Since 3.7 kernel, the firmware loader can read the firmware files > directly, and the traditional user-mode helper is invoked only as a > fallback. This seems working pretty well, and the next step would be > to reduce the redun