Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-12 Thread NeilBrown
On Tue, Dec 12 2017, Amir Goldstein wrote: > On Mon, Dec 11, 2017 at 11:52 PM, NeilBrown wrote: >> On Mon, Dec 11 2017, Amir Goldstein wrote: >> >>> On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: If a filesystem does not set sb->s_export_op, then it does not support filehandles and

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-11 Thread Amir Goldstein
On Mon, Dec 11, 2017 at 11:52 PM, NeilBrown wrote: > On Mon, Dec 11 2017, Amir Goldstein wrote: > >> On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: >>> If a filesystem does not set sb->s_export_op, then it >>> does not support filehandles and export_fs_encode_fh() >>> and exportfs_encode_inode

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-11 Thread NeilBrown
On Mon, Dec 11 2017, Al Viro wrote: > On Mon, Dec 11, 2017 at 05:04:05PM +1100, NeilBrown wrote: >> @@ -385,7 +385,9 @@ int exportfs_encode_inode_fh(struct inode *inode, struct >> fid *fid, >> { >> const struct export_operations *nop = inode->i_sb->s_export_op; >> >> -if (nop && nop->

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-11 Thread NeilBrown
On Mon, Dec 11 2017, Amir Goldstein wrote: > On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: >> If a filesystem does not set sb->s_export_op, then it >> does not support filehandles and export_fs_encode_fh() >> and exportfs_encode_inode_fh() should not be called. >> They will use export_encode_

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-11 Thread Pavel Emelyanov
On 12/11/2017 05:08 PM, Amir Goldstein wrote: > On Mon, Dec 11, 2017 at 3:46 PM, Pavel Emelyanov wrote: >> On 12/11/2017 10:05 AM, Amir Goldstein wrote: >>> On Mon, Dec 11, 2017 at 8:41 AM, Amir Goldstein wrote: On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: > If a filesystem does no

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-11 Thread Amir Goldstein
On Mon, Dec 11, 2017 at 3:46 PM, Pavel Emelyanov wrote: > On 12/11/2017 10:05 AM, Amir Goldstein wrote: >> On Mon, Dec 11, 2017 at 8:41 AM, Amir Goldstein wrote: >>> On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: If a filesystem does not set sb->s_export_op, then it does not support

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-11 Thread Pavel Emelyanov
On 12/11/2017 10:05 AM, Amir Goldstein wrote: > On Mon, Dec 11, 2017 at 8:41 AM, Amir Goldstein wrote: >> On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: >>> If a filesystem does not set sb->s_export_op, then it >>> does not support filehandles and export_fs_encode_fh() >>> and exportfs_encode_

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-10 Thread Amir Goldstein
On Mon, Dec 11, 2017 at 8:41 AM, Amir Goldstein wrote: > On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: >> If a filesystem does not set sb->s_export_op, then it >> does not support filehandles and export_fs_encode_fh() >> and exportfs_encode_inode_fh() should not be called. >> They will use ex

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-10 Thread Amir Goldstein
On Mon, Dec 11, 2017 at 8:04 AM, NeilBrown wrote: > If a filesystem does not set sb->s_export_op, then it > does not support filehandles and export_fs_encode_fh() > and exportfs_encode_inode_fh() should not be called. > They will use export_encode_fh() is which is a default > that uses inode numbe

Re: [PATCH 1/4] fs/notify: fdinfo can report unsupported file handles.

2017-12-10 Thread Al Viro
On Mon, Dec 11, 2017 at 05:04:05PM +1100, NeilBrown wrote: > @@ -385,7 +385,9 @@ int exportfs_encode_inode_fh(struct inode *inode, struct > fid *fid, > { > const struct export_operations *nop = inode->i_sb->s_export_op; > > - if (nop && nop->encode_fh) > + if (nop) > +