Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-03 Thread Thomas Gleixner
On Thu, 2 Aug 2018, Ricardo Neri wrote: > On Thu, Aug 02, 2018 at 11:40:55AM +0200, Thomas Gleixner wrote: > > Yes, focussing on "sane" architectures (by some definition of sane) where > > the NMI mode is just changing the delivery restrictions allows to still > > differentiate from which source th

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-02 Thread Ricardo Neri
On Thu, Aug 02, 2018 at 11:40:55AM +0200, Thomas Gleixner wrote: > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > On Thu, 02 Aug 2018 07:55:49 +0100, > > Thomas Gleixner wrote: > > > > > > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > > > > > > > If we need to distinguish between the two, then we nee

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-02 Thread Thomas Gleixner
On Thu, 2 Aug 2018, Marc Zyngier wrote: > On Thu, 02 Aug 2018 07:55:49 +0100, > Thomas Gleixner wrote: > > > > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > > > > > If we need to distinguish between the two, then we need two flags. One > > > that indicates the generation capability, and one that i

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-02 Thread Marc Zyngier
On Thu, 02 Aug 2018 07:55:49 +0100, Thomas Gleixner wrote: > > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > > > If we need to distinguish between the two, then we need two flags. One > > that indicates the generation capability, and one that indicates the > > forwarding capability. > > There is

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-01 Thread Thomas Gleixner
On Thu, 2 Aug 2018, Marc Zyngier wrote: > On Thu, 02 Aug 2018 03:03:20 +0100, > Ricardo Neri wrote: > > On Wed, Aug 01, 2018 at 04:09:59PM +0100, Julien Thierry wrote: > > > > > > > >I don't think this works in x86 because the local APIC irq_chip is the > > > >root of the hierarchy; the rest of th

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-01 Thread Marc Zyngier
On Thu, 02 Aug 2018 03:03:20 +0100, Ricardo Neri wrote: > > On Wed, Aug 01, 2018 at 04:09:59PM +0100, Julien Thierry wrote: > > >>+static bool irq_supports_nmi(struct irq_desc *desc) > > >>+{ > > >>+ struct irq_data *d = irq_desc_get_irq_data(desc); > > >>+ > > >>+#ifdef CONFIG_IRQ_DOMAIN_HIERARC

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-01 Thread Ricardo Neri
On Wed, Aug 01, 2018 at 04:09:59PM +0100, Julien Thierry wrote: > >>+static bool irq_supports_nmi(struct irq_desc *desc) > >>+{ > >>+ struct irq_data *d = irq_desc_get_irq_data(desc); > >>+ > >>+#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY > >>+ /* Only IRQs directly managed by the root irqchip can be se

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-01 Thread Joe Perches
On Wed, 2018-08-01 at 16:09 +0100, Julien Thierry wrote: > On 01/08/18 04:07, Ricardo Neri wrote: > > On Tue, Jul 24, 2018 at 12:07:04PM +0100, Julien Thierry wrote: > > > + || WARN_ON(irq_settings_is_per_cpu_devid(desc)) > > > + || !irq_supports_nmi(desc)) > > > > Shouldn't the logical op

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-01 Thread Julien Thierry
Hi Ricardo, On 01/08/18 04:07, Ricardo Neri wrote: On Tue, Jul 24, 2018 at 12:07:04PM +0100, Julien Thierry wrote: Hi Julien, Many thanks for your patchset and I apologize for the late reply. I tried to use your patches on my own use case and I have the following comments... Add functionalit

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-07-31 Thread Ricardo Neri
On Tue, Jul 24, 2018 at 12:07:04PM +0100, Julien Thierry wrote: Hi Julien, Many thanks for your patchset and I apologize for the late reply. I tried to use your patches on my own use case and I have the following comments... > Add functionality to allocate interrupt lines that will deliver IRQs