Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags

2013-02-02 Thread Len Brown
>> I think that a driver's private flag definitions >> should remain local to the driver. It makes no sense >> to pollute the name space of other drivers for stuff >> that doesn't mean anything to them. MWAIT is pretty >> specific to x86 -- and re-naming it to something 'generic' >> isn't going

Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags

2013-02-02 Thread Daniel Lezcano
On 02/02/2013 03:16 AM, Len Brown wrote: > >>> intel_idle already uses a driver-specific flag: >>> >>> #define CPUIDLE_FLAG_TLB_FLUSHED0x1 >>> >>> This patch just uses 4 more bits along with that one. >> >> Ok. In this case it would make sense to move this flag out of the >> generic co

Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags

2013-02-01 Thread Len Brown
>> intel_idle already uses a driver-specific flag: >> >> #define CPUIDLE_FLAG_TLB_FLUSHED0x1 >> >> This patch just uses 4 more bits along with that one. > > Ok. In this case it would make sense to move this flag out of the > generic core code to the intel_idle.c file ? This flag is a

Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags

2013-02-01 Thread Daniel Lezcano
On 02/01/2013 07:40 PM, Len Brown wrote: > On 02/01/2013 03:44 AM, Daniel Lezcano wrote: >> On 02/01/2013 05:11 AM, Len Brown wrote: >>> From: Len Brown >>> >>> The commit, 4202735e8ab6ecfb0381631a0d0b58fefe0bd4e2 >>> (cpuidle: Split cpuidle_state structure and move per-cpu statistics fields) >>>

Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags

2013-02-01 Thread Len Brown
On 02/01/2013 03:44 AM, Daniel Lezcano wrote: > On 02/01/2013 05:11 AM, Len Brown wrote: >> From: Len Brown >> >> The commit, 4202735e8ab6ecfb0381631a0d0b58fefe0bd4e2 >> (cpuidle: Split cpuidle_state structure and move per-cpu statistics fields) >> observed that the MWAIT flags for Cn on every pro

Re: [PATCH 1/4] intel_idle: stop using driver_data for static flags

2013-02-01 Thread Daniel Lezcano
On 02/01/2013 05:11 AM, Len Brown wrote: > From: Len Brown > > The commit, 4202735e8ab6ecfb0381631a0d0b58fefe0bd4e2 > (cpuidle: Split cpuidle_state structure and move per-cpu statistics fields) > observed that the MWAIT flags for Cn on every processor to date were the > same, and created get_driv