Re: [PATCH 1/4] kbuild: remove LLVM=1 test from HAS_LTO_CLANG

2021-03-08 Thread Sami Tolvanen
On Wed, Mar 3, 2021 at 12:47 PM Nick Desaulniers wrote: > > + Sami > > On Wed, Mar 3, 2021 at 10:34 AM Masahiro Yamada wrote: > > > > This guarding is wrong. As Documentation/kbuild/llvm.rst notes, LLVM=1 > > switches the default of tools, but you can still override CC, LD, etc. > > individually.

Re: [PATCH 1/4] kbuild: remove LLVM=1 test from HAS_LTO_CLANG

2021-03-04 Thread Masahiro Yamada
On Thu, Mar 4, 2021 at 5:47 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > + Sami > > On Wed, Mar 3, 2021 at 10:34 AM Masahiro Yamada wrote: > > > > This guarding is wrong. As Documentation/kbuild/llvm.rst notes, LLVM=1 > > switches the default of tools, but you can still override CC, LD,

Re: [PATCH 1/4] kbuild: remove LLVM=1 test from HAS_LTO_CLANG

2021-03-03 Thread Nathan Chancellor
On Thu, Mar 04, 2021 at 03:33:30AM +0900, Masahiro Yamada wrote: > This guarding is wrong. As Documentation/kbuild/llvm.rst notes, LLVM=1 > switches the default of tools, but you can still override CC, LD, etc. > individually. > > BTW, LLVM is not 1/0 flag. If LLVM is not passed in, it is empty. >

Re: [PATCH 1/4] kbuild: remove LLVM=1 test from HAS_LTO_CLANG

2021-03-03 Thread Nick Desaulniers
+ Sami On Wed, Mar 3, 2021 at 10:34 AM Masahiro Yamada wrote: > > This guarding is wrong. As Documentation/kbuild/llvm.rst notes, LLVM=1 > switches the default of tools, but you can still override CC, LD, etc. > individually. > > BTW, LLVM is not 1/0 flag. If LLVM is not passed in, it is empty.