Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated

2014-10-24 Thread Michal Nazarewicz
> On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: >> As a matter of fact, this is present in kernels earlier than 3.17 but in >> the 3.17 the code has been moved from drivers/base/dma-contiguous.c to >> mm/cma.c so this might require separate stable patch. On Fri, Oct 24 2014, Lauren

Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated

2014-10-24 Thread Laurent Pinchart
Hello, On Friday 24 October 2014 11:50:14 Joonsoo Kim wrote: > On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote: > > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart wrote: > > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: > > >> On Thu, Oct 23 2014, Laurent Pinchart

Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated

2014-10-23 Thread Joonsoo Kim
On Fri, Oct 24, 2014 at 10:02:49AM +0800, Weijie Yang wrote: > On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart > wrote: > > Hi Michal, > > > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: > >> On Thu, Oct 23 2014, Laurent Pinchart wrote: > >> > If activation of the CMA area fail

Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated

2014-10-23 Thread Weijie Yang
On Fri, Oct 24, 2014 at 7:42 AM, Laurent Pinchart wrote: > Hi Michal, > > On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: >> On Thu, Oct 23 2014, Laurent Pinchart wrote: >> > If activation of the CMA area fails its mutex won't be initialized, >> > leading to an oops at allocation tim

Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated

2014-10-23 Thread Laurent Pinchart
Hi Michal, On Thursday 23 October 2014 18:53:36 Michal Nazarewicz wrote: > On Thu, Oct 23 2014, Laurent Pinchart wrote: > > If activation of the CMA area fails its mutex won't be initialized, > > leading to an oops at allocation time when trying to lock the mutex. Fix > > this by failing allocatio

Re: [PATCH 1/4] mm: cma: Don't crash on allocation if CMA area can't be activated

2014-10-23 Thread Michal Nazarewicz
On Thu, Oct 23 2014, Laurent Pinchart wrote: > If activation of the CMA area fails its mutex won't be initialized, > leading to an oops at allocation time when trying to lock the mutex. Fix > this by failing allocation if the area hasn't been successfully actived, > and detect that condition by mov