Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-28 Thread Linus Walleij
On Tue, Aug 27, 2013 at 11:19 AM, Mateusz Krawczuk wrote: > This patch implements pinctrl for s5pv210 and adds required device tree > bindings. > > Signed-off-by: Mateusz Krawczuk Bindings is something you add in Documentation/devicetree/bindings, so atleast alter the commit message. This mere

Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Mateusz Krawczuk
On 08/27/2013 02:22 PM, Tomasz Figa wrote: Hi Mateusz, Is this a series of 4 patches? Apparently I have received only this one. No, I send wrong version of this patch, other patches are completely unrelated to this one. On Tuesday 27 of August 2013 11:19:31 Mateusz Krawczuk wrote: This patc

Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Tomasz Figa
Hi Sylwester, On Tuesday 27 of August 2013 11:30:09 Sylwester Nawrocki wrote: > Hi, > > Just a few nits... > > On 08/27/2013 11:19 AM, Mateusz Krawczuk wrote: > > This patch implements pinctrl for s5pv210 and adds required device tree > > bindings. > Would be good to wrap this to not exceed 80 c

Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Tomasz Figa
Hi Mateusz, Is this a series of 4 patches? Apparently I have received only this one. On Tuesday 27 of August 2013 11:19:31 Mateusz Krawczuk wrote: > This patch implements pinctrl for s5pv210 and adds required device tree > bindings. This should be wrapped to have lines shorter than 80 characters

Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Mateusz Krawczuk
On 08/27/2013 11:30 AM, Sylwester Nawrocki wrote: Hi, Just a few nits... On 08/27/2013 11:19 AM, Mateusz Krawczuk wrote: This patch implements pinctrl for s5pv210 and adds required device tree bindings. Would be good to wrap this to not exceed 80 columns. Signed-off-by: Mateusz Krawczuk -

Re: [PATCH 1/4] pinctrl: Add s5pv210 support to pinctrl-exynos

2013-08-27 Thread Sylwester Nawrocki
Hi, Just a few nits... On 08/27/2013 11:19 AM, Mateusz Krawczuk wrote: > This patch implements pinctrl for s5pv210 and adds required device tree > bindings. Would be good to wrap this to not exceed 80 columns. > Signed-off-by: Mateusz Krawczuk > --- [...] > diff --git a/drivers/pinctrl/pinctr