Re: [PATCH 1/4] pinctrl: Remove duplicate code in pinctrl_pm_select_state functions

2013-07-22 Thread Linus Walleij
On Thu, Jul 18, 2013 at 5:15 PM, Tony Lindgren wrote: > There's no need to duplicate essentially the same functions. Let's > introduce static int pinctrl_pm_select_state() and make the other > related functions call that. > > This allows us to add support later on for multiple active states, > an

Re: [PATCH 1/4] pinctrl: Remove duplicate code in pinctrl_pm_select_state functions

2013-07-16 Thread Tony Lindgren
* Grygorii Strashko [130716 07:32]: > Hi Tony, > > On 07/16/2013 04:41 PM, Tony Lindgren wrote: > >* Grygorii Strashko [130716 06:22]: > >>Hi Tony, > >> > >>This patch causes boot failure when I've applied my patch > >>"[RFC] ARM: OMAP2+: omap_device: add pinctrl handling" > >>https://lkml.org/l

Re: [PATCH 1/4] pinctrl: Remove duplicate code in pinctrl_pm_select_state functions

2013-07-16 Thread Grygorii Strashko
Hi Tony, On 07/16/2013 04:41 PM, Tony Lindgren wrote: * Grygorii Strashko [130716 06:22]: Hi Tony, This patch causes boot failure when I've applied my patch "[RFC] ARM: OMAP2+: omap_device: add pinctrl handling" https://lkml.org/lkml/2013/6/21/309 on top of it: Hmm this patch alone removes

Re: [PATCH 1/4] pinctrl: Remove duplicate code in pinctrl_pm_select_state functions

2013-07-16 Thread Tony Lindgren
* Grygorii Strashko [130716 06:22]: > Hi Tony, > > This patch causes boot failure when I've applied my patch > "[RFC] ARM: OMAP2+: omap_device: add pinctrl handling" > https://lkml.org/lkml/2013/6/21/309 > > on top of it: Hmm this patch alone removes duplicate code and if it causes issues I must

Re: [PATCH 1/4] pinctrl: Remove duplicate code in pinctrl_pm_select_state functions

2013-07-16 Thread Grygorii Strashko
Hi Tony, This patch causes boot failure when I've applied my patch "[RFC] ARM: OMAP2+: omap_device: add pinctrl handling" https://lkml.org/lkml/2013/6/21/309 on top of it: [0.264007] L310 cache controller enabled [0.268310] l2x0: 16 ways, CACHE_ID 0x41c4, AUX_CTRL 0x7e47, Cache