Re: [PATCH 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-28 Thread Doug Anderson
Linus, On Tue, Oct 28, 2014 at 8:51 AM, Linus Walleij wrote: > On Tue, Oct 21, 2014 at 1:27 AM, Doug Anderson wrote: > >> The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup >> the .wake_enabled member. That means that we can never actually use a >> pin for wakeup. When "irq_s

Re: [PATCH 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-28 Thread Linus Walleij
On Tue, Oct 21, 2014 at 1:27 AM, Doug Anderson wrote: > The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup > the .wake_enabled member. That means that we can never actually use a > pin for wakeup. When "irq_set_irq_wake()" tries to call through it > will always get a failure f

Re: [PATCH 1/4] pinctrl: rockchip: Set wake_enabled

2014-10-20 Thread Chris Zhong
Tested-by: Chris Zhong On 10/20/2014 04:27 PM, Doug Anderson wrote: The rockchip pinctrl driver uses irq_gc_set_wake() but doesn't setup the .wake_enabled member. That means that we can never actually use a pin for wakeup. When "irq_set_irq_wake()" tries to call through it will always get a f