On Mon, 15 Jun 2020 15:11:39 -0400
Steven Rostedt wrote:
> On Sat, 13 Jun 2020 00:23:18 +0900
> Masami Hiramatsu wrote:
>
> > Fix /proc/bootconfig to show the correctly choose the
> > double or single quotes according to the value.
> >
> > If a bootconfig value includes a double quote characte
On Mon, 2020-06-15 at 16:12 -0700, Randy Dunlap wrote:
> On 6/15/20 3:42 PM, Steven Rostedt wrote:
> > On Mon, 15 Jun 2020 15:30:41 -0700
> > Randy Dunlap wrote:
> >
> > > > > Please don't infect kernel sources with that style oddity.
> > > >
> > > > What do you mean? It's already "infected" a
On 6/15/20 3:42 PM, Steven Rostedt wrote:
> On Mon, 15 Jun 2020 15:30:41 -0700
> Randy Dunlap wrote:
>
Please don't infect kernel sources with that style oddity.
>>>
>>> What do you mean? It's already "infected" all over the kernel, (has
>>> been for years!) and I kinda like it. It makes r
On Mon, 15 Jun 2020 15:30:41 -0700
Randy Dunlap wrote:
> >> Please don't infect kernel sources with that style oddity.
> >
> > What do you mean? It's already "infected" all over the kernel, (has
> > been for years!) and I kinda like it. It makes reading variables much
> > easier on the eyes, a
On 6/15/20 2:21 PM, Steven Rostedt wrote:
> On Mon, 15 Jun 2020 12:24:00 -0700
> Joe Perches wrote:
>
>>> Hmm, shouldn't the above have the upside-down xmas tree format?
>>>
>>> struct xbc_node *leaf, *vnode;
>>> char *key, *end = dst + size;
>>> const char *val;
>>> char q;
>>>
On Mon, 15 Jun 2020 12:24:00 -0700
Joe Perches wrote:
> > Hmm, shouldn't the above have the upside-down xmas tree format?
> >
> > struct xbc_node *leaf, *vnode;
> > char *key, *end = dst + size;
> > const char *val;
> > char q;
> > int ret = 0;
>
> Please don't infect kern
On Mon, 2020-06-15 at 15:11 -0400, Steven Rostedt wrote:
> On Sat, 13 Jun 2020 00:23:18 +0900
> Masami Hiramatsu wrote:
[]
> > diff --git a/fs/proc/bootconfig.c b/fs/proc/bootconfig.c
[]
> > @@ -27,6 +27,7 @@ static int __init copy_xbc_key_value_list(char *dst,
> > size_t size)
> > {
> > str
On Sat, 13 Jun 2020 00:23:18 +0900
Masami Hiramatsu wrote:
> Fix /proc/bootconfig to show the correctly choose the
> double or single quotes according to the value.
>
> If a bootconfig value includes a double quote character,
> we must use single-quotes to quote that value.
>
> Fixes: c1a3c3601
On Fri, Jun 12, 2020 at 06:15:13PM +0200, Markus Elfring wrote:
> > Fix /proc/bootconfig to show the correctly choose the
> > double or single quotes according to the value.
>
> I suggest to improve this wording a bit.
>
> Regards,
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
On Sat, 13 Jun 2020 00:23:18 +0900
Masami Hiramatsu wrote:
> Fix /proc/bootconfig to show the correctly choose the
> double or single quotes according to the value.
Oops, I missed to remove "show".
Fix /proc/bootconfig to correctly choose the
double or single quotes according to the value.
>
> Fix /proc/bootconfig to show the correctly choose the
> double or single quotes according to the value.
I suggest to improve this wording a bit.
Regards,
Markus
11 matches
Mail list logo
