Re: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller

2014-11-27 Thread Mark Brown
On Thu, Nov 27, 2014 at 03:05:08PM +, Lee Jones wrote: > > > + /* Set SSC_CTL to 16 bits-per-word */ > > > + ctl = readl_relaxed(spi_st->base + SSC_CTL); > > > + writel_relaxed((ctl | 0xf), spi_st->base + SSC_CTL); > > > + readl_relaxed(spi_st->base + SSC_RBUF)

Re: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller

2014-11-27 Thread Lee Jones
[...] > > +struct spi_st { > > + /* SSC SPI Controller */ > > + struct spi_bitbang bitbang; > > Is there a good reason for using bitbang over the core transmit_one() > interface? The operations are basically the same but more modern and > the functionality is more discoverable. I don't

Re: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller

2014-11-27 Thread Maxime Coquelin
On 11/27/2014 12:43 PM, Lee Jones wrote: This patch adds support for the SPI portion of ST's SSC device. Signed-off-by: Lee Jones --- drivers/spi/Kconfig | 8 + drivers/spi/Makefile | 1 + drivers/spi/spi-st.c | 535 +++ 3 files changed

Re: [PATCH 1/4] spi: Add new driver for STMicroelectronics' SPI Controller

2014-11-27 Thread Mark Brown
On Thu, Nov 27, 2014 at 11:43:53AM +, Lee Jones wrote: > +config SPI_ST > + tristate "STMicroelectronics SPI SSC-based driver" Please select a more specific symbol, I bet ST already have other sPI controllers. Based on the descripton SPI_ST_SSC might work. > + depends on ARCH_STI P