Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2008-02-22 Thread David Brownell
On Friday 22 February 2008, Anton Vorontsov wrote: > > +static inline int gpio_request(unsigned gpio, const char *label) > > +{ > > + return -EINVAL; > > Could we return -ENOSYS instead, so drivers will able to distinguish > between "something really failed" and "there is no gpio support, > fa

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2008-02-22 Thread Anton Vorontsov
On Wed, Feb 13, 2008 at 05:55:30PM -0800, David Brownell wrote: > On Wednesday 13 February 2008, Andrew Morton wrote: > > It would be more modern to have a which takes care of > > cruddy details, but it's getting too late for that. > > Sort of like this? For drivers that don't want to list thems

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2008-02-13 Thread David Brownell
On Wednesday 13 February 2008, Andrew Morton wrote: > It would be more modern to have a which takes care of > cruddy details, but it's getting too late for that. Sort of like this? For drivers that don't want to list themselves in Kconfig as depending on GENERIC_GPIO (e.g. one NAND driver I hear

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2008-02-13 Thread David Brownell
On Wednesday 13 February 2008, Andrew Morton wrote: > Someone please fix. This is what I was using purely for test builds ... most x86 hardware actually has no GPIOs, and I sure don't have any of the "unusual" x86 platforms here, so I'd not want to see this version merge. Someone more clued in on

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2008-02-13 Thread Andrew Morton
On Thu, 18 Oct 2007 15:51:24 +0200 Florian Fainelli <[EMAIL PROTECTED]> wrote: > This patch adds the generic GPIO support to the x86 > architecture. We do the same as for MIPS, we let > the machine override the gpio callbacks and provide > defaults one in mach-generic. > > Signed-off-by: Florian

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-25 Thread Thomas Gleixner
On Thu, 25 Oct 2007, Florian Fainelli wrote: > > It might be useful for everyone to check, whether the existing GPIO > > functionality can be extended, reworked to match the needs of Geode as > > well. Extending / reworking an existing interface is definitely > > better than adding a new incompatib

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-25 Thread Florian Fainelli
Hi, Le jeudi 25 octobre 2007, Thomas Gleixner a écrit : > It might be useful for everyone to check, whether the existing GPIO > functionality can be extended, reworked to match the needs of Geode as > well. Extending / reworking an existing interface is definitely > better than adding a new incomp

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-25 Thread Thomas Gleixner
On Mon, 22 Oct 2007, Andres Salomon wrote: > On Fri, 19 Oct 2007 14:01:56 +0200 > Florian Fainelli <[EMAIL PROTECTED]> wrote: > > > Hi Andres, > > > > Le jeudi 18 octobre 2007, Andres Salomon a écrit : > > > While I certainly would like to see a generic GPIO API, this one > > > isn't really usefu

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-22 Thread Florian Fainelli
Hi Andres, Le lundi 22 octobre 2007, Andres Salomon a écrit : > How does being used on MIPS and ARM make it suitable for x86? If > you're arguing that other x86 platforms conform to it, and it might be > useful for them; sure, I'll buy that. That doesn't seem to currently be > the case, though.

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-22 Thread Andres Salomon
On Fri, 19 Oct 2007 14:01:56 +0200 Florian Fainelli <[EMAIL PROTECTED]> wrote: > Hi Andres, > > Le jeudi 18 octobre 2007, Andres Salomon a écrit : > > While I certainly would like to see a generic GPIO API, this one > > isn't really useful for geode GPIOs. It would be nice to have one > > that d

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-21 Thread Haavard Skinnemoen
On Fri, 19 Oct 2007 21:32:08 + (UTC) Jordan Crouse <[EMAIL PROTECTED]> wrote: > > This one was discussed mostly on the ARM mailing-list and finally > > made his way to the mainline kernel. Though it lacks some functions > > to change for instance a entire GPIO line and not a single bit, it > >

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-19 Thread Jordan Crouse
On Fri, 19 Oct 2007 14:01:56 +0200, Florian Fainelli wrote: > Hi Andres, > > Le jeudi 18 octobre 2007, Andres Salomon a écrit : >> While I certainly would like to see a generic GPIO API, this one isn't >> really useful for geode GPIOs. It would be nice to have one that did >> work for us as well

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-19 Thread Florian Fainelli
Hi Andres, Le jeudi 18 octobre 2007, Andres Salomon a écrit : > While I certainly would like to see a generic GPIO API, this one isn't > really useful for geode GPIOs. It would be nice to have one that did > work for us as well. Unfortunately, I haven't had the chance to give > much thought to t

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2007-10-18 Thread Andres Salomon
On Thu, 18 Oct 2007 15:51:24 +0200 Florian Fainelli <[EMAIL PROTECTED]> wrote: > This patch adds the generic GPIO support to the x86 > architecture. We do the same as for MIPS, we let > the machine override the gpio callbacks and provide > defaults one in mach-generic. > [...] > + > +int gpio_req