Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-10-08 Thread joeyli
Hi Any, Jann, On Wed, Oct 03, 2018 at 03:08:12PM -0700, Andy Lutomirski wrote: > On Tue, Oct 2, 2018 at 12:36 PM Jann Horn wrote: > > > > +Andy for opinions on things in write handlers > > +Mimi Zohar as EVM maintainer > > > > On Tue, Oct 2, 2018 at 9:55 AM joeyli wrote: > > > On Thu, Sep 13, 20

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-10-03 Thread Mimi Zohar
On Tue, 2018-10-02 at 21:36 +0200, Jann Horn wrote: > +Andy for opinions on things in write handlers > +Mimi Zohar as EVM maintainer > > On Tue, Oct 2, 2018 at 9:55 AM joeyli wrote: > > On Thu, Sep 13, 2018 at 04:31:18PM +0200, Jann Horn wrote: > > > On Thu, Sep 13, 2018 at 4:08 PM Lee, Chun-Yi

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-10-03 Thread Andy Lutomirski
On Tue, Oct 2, 2018 at 12:36 PM Jann Horn wrote: > > +Andy for opinions on things in write handlers > +Mimi Zohar as EVM maintainer > > On Tue, Oct 2, 2018 at 9:55 AM joeyli wrote: > > On Thu, Sep 13, 2018 at 04:31:18PM +0200, Jann Horn wrote: > > > On Thu, Sep 13, 2018 at 4:08 PM Lee, Chun-Yi

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-10-02 Thread Jann Horn
+Andy for opinions on things in write handlers +Mimi Zohar as EVM maintainer On Tue, Oct 2, 2018 at 9:55 AM joeyli wrote: > On Thu, Sep 13, 2018 at 04:31:18PM +0200, Jann Horn wrote: > > On Thu, Sep 13, 2018 at 4:08 PM Lee, Chun-Yi > > wrote: > > > This patch adds a snapshot keys handler for us

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-10-02 Thread joeyli
Hi Jann, Thanks for your review and very sorry for my delay! On Thu, Sep 13, 2018 at 04:31:18PM +0200, Jann Horn wrote: > +cc keyrings list > > On Thu, Sep 13, 2018 at 4:08 PM Lee, Chun-Yi wrote: > > This patch adds a snapshot keys handler for using the key retention > > service api to create k

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-10-01 Thread joeyli
Hi Yu Chen, Thanks for your review and very sorry for my delay! On Thu, Sep 13, 2018 at 09:58:32PM +0800, Yu Chen wrote: > On Wed, Sep 12, 2018 at 10:23:33PM +0800, Lee, Chun-Yi wrote: > > This patch adds a snapshot keys handler for using the key retention > > service api to create keys for snap

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-09-13 Thread kbuild test robot
Hi Chun-Yi, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc3 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commit

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-09-13 Thread Jann Horn
+cc keyrings list On Thu, Sep 13, 2018 at 4:08 PM Lee, Chun-Yi wrote: > This patch adds a snapshot keys handler for using the key retention > service api to create keys for snapshot image encryption and > authentication. > > This handler uses TPM trusted key as the snapshot master key, and the >

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-09-13 Thread Yu Chen
On Wed, Sep 12, 2018 at 10:23:33PM +0800, Lee, Chun-Yi wrote: > This patch adds a snapshot keys handler for using the key retention > service api to create keys for snapshot image encryption and > authentication. > > This handler uses TPM trusted key as the snapshot master key, and the > encryptio

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-09-13 Thread joeyli
Hi Randy, On Wed, Sep 12, 2018 at 09:27:27AM -0700, Randy Dunlap wrote: > Hi, > > On 9/12/18 7:23 AM, Lee, Chun-Yi wrote: > > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig > > index 3a6c2f87699e..7c5c30149dbc 100644 > > --- a/kernel/power/Kconfig > > +++ b/kernel/power/Kconfig > > @@ -

Re: [PATCH 1/5] PM / hibernate: Create snapshot keys handler

2018-09-12 Thread Randy Dunlap
Hi, On 9/12/18 7:23 AM, Lee, Chun-Yi wrote: > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig > index 3a6c2f87699e..7c5c30149dbc 100644 > --- a/kernel/power/Kconfig > +++ b/kernel/power/Kconfig > @@ -76,6 +76,20 @@ config HIBERNATION > > For more information take a look at > .