Re: [PATCH 1/5] mm/debug_pagealloc: clean-up guard page handling code

2016-08-15 Thread Joonsoo Kim
On Fri, Aug 12, 2016 at 09:25:37PM +0900, Sergey Senozhatsky wrote: > On (08/11/16 11:41), Vlastimil Babka wrote: > > On 08/10/2016 10:14 AM, Sergey Senozhatsky wrote: > > > > @@ -1650,18 +1655,15 @@ static inline void expand(struct zone *zone, > > > > struct page *page, > > > > si

Re: [PATCH 1/5] mm/debug_pagealloc: clean-up guard page handling code

2016-08-12 Thread Sergey Senozhatsky
On (08/11/16 11:41), Vlastimil Babka wrote: > On 08/10/2016 10:14 AM, Sergey Senozhatsky wrote: > > > @@ -1650,18 +1655,15 @@ static inline void expand(struct zone *zone, > > > struct page *page, > > > size >>= 1; > > > VM_BUG_ON_PAGE(bad_range(zone, &page[size]), &page[size]);

Re: [PATCH 1/5] mm/debug_pagealloc: clean-up guard page handling code

2016-08-11 Thread Vlastimil Babka
On 08/10/2016 10:14 AM, Sergey Senozhatsky wrote: @@ -1650,18 +1655,15 @@ static inline void expand(struct zone *zone, struct page *page, size >>= 1; VM_BUG_ON_PAGE(bad_range(zone, &page[size]), &page[size]); - if (IS_ENABLED(CONFIG_DEBUG_PAGEALLOC)

Re: [PATCH 1/5] mm/debug_pagealloc: clean-up guard page handling code

2016-08-11 Thread Vlastimil Babka
On 08/10/2016 08:16 AM, js1...@gmail.com wrote: From: Joonsoo Kim We can make code clean by moving decision condition for set_page_guard() into set_page_guard() itself. It will help code readability. There is no functional change. Signed-off-by: Joonsoo Kim Acked-by: Vlastimil Babka

Re: [PATCH 1/5] mm/debug_pagealloc: clean-up guard page handling code

2016-08-10 Thread Sergey Senozhatsky
Hello, On (08/10/16 15:16), js1...@gmail.com wrote: [..] > -static inline void set_page_guard(struct zone *zone, struct page *page, > +static inline bool set_page_guard(struct zone *zone, struct page *page, > unsigned int order, int migratetype) > { > struct pa