Re: [PATCH 1/5] perf metricgroup: Support printing metrics for arm64

2021-03-11 Thread John Garry
On 06/03/2021 19:34, Jiri Olsa wrote: On Fri, Mar 05, 2021 at 11:06:58AM +, John Garry wrote: Hi Jirka, - struct pmu_events_map *map = perf_pmu__find_map(NULL); + struct pmu_events_map *map = find_cpumap(); so this is just for arm at the moment right? Yes - but to be more ac

Re: [PATCH 1/5] perf metricgroup: Support printing metrics for arm64

2021-03-08 Thread John Garry
On 06/03/2021 19:34, Jiri Olsa wrote: On Fri, Mar 05, 2021 at 11:06:58AM +, John Garry wrote: Hi Jirka, - struct pmu_events_map *map = perf_pmu__find_map(NULL); + struct pmu_events_map *map = find_cpumap(); so this is just for arm at the moment right? Yes - but to be more ac

Re: [PATCH 1/5] perf metricgroup: Support printing metrics for arm64

2021-03-06 Thread Jiri Olsa
On Fri, Mar 05, 2021 at 11:06:58AM +, John Garry wrote: > > Hi Jirka, > > > > - struct pmu_events_map *map = perf_pmu__find_map(NULL); > > > + struct pmu_events_map *map = find_cpumap(); > > so this is just for arm at the moment right? > > > > Yes - but to be more accurate, arm64. > > At t

Re: [PATCH 1/5] perf metricgroup: Support printing metrics for arm64

2021-03-05 Thread John Garry
Hi Jirka, - struct pmu_events_map *map = perf_pmu__find_map(NULL); + struct pmu_events_map *map = find_cpumap(); so this is just for arm at the moment right? Yes - but to be more accurate, arm64. At the moment, from the archs which use pmu-events, only arm64 and nds32 have ve

Re: [PATCH 1/5] perf metricgroup: Support printing metrics for arm64

2021-03-04 Thread Jiri Olsa
On Wed, Mar 03, 2021 at 11:22:14PM +0800, John Garry wrote: > Calling perf_pmu__find_map(NULL) returns the cpumap for the common CPU > PMU. However arm64 supports heterogeneous-CPU based systems, and so there > may be no common CPU PMU. As such, perf_pmu__find_map(NULL) returns NULL > for arm64. >