Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

2021-02-08 Thread Alexey Dobriyan
On Mon, Feb 08, 2021 at 04:25:35PM +0100, Peter Zijlstra wrote: > On Mon, Feb 08, 2021 at 05:52:45PM +0300, Alexey Dobriyan wrote: > > On Mon, Feb 08, 2021 at 05:30:25PM +0300, Alexey Dobriyan wrote: > > > On Mon, Feb 08, 2021 at 11:34:18AM +0100, Peter Zijlstra wrote: > > > > On Sat, Feb 06, 2021

Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

2021-02-08 Thread Peter Zijlstra
On Mon, Feb 08, 2021 at 05:52:45PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 08, 2021 at 05:30:25PM +0300, Alexey Dobriyan wrote: > > On Mon, Feb 08, 2021 at 11:34:18AM +0100, Peter Zijlstra wrote: > > > On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote: > > > > > > > Silently dele

Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

2021-02-08 Thread Alexey Dobriyan
On Mon, Feb 08, 2021 at 05:30:25PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 08, 2021 at 11:34:18AM +0100, Peter Zijlstra wrote: > > On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote: > > > > > Silently delete "extern" from prototypes. > > > > NAK, extern is right. > > Extern is

Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

2021-02-08 Thread Alexey Dobriyan
On Mon, Feb 08, 2021 at 11:39:25AM +0100, Peter Zijlstra wrote: > On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote: > > 32-bit accesses are shorter than 64-bit accesses on x86_64. > > Nothing uses 64-bitness of struct task_struct::state. > > > > Propagate 32-bitness to other variabl

Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

2021-02-08 Thread Alexey Dobriyan
On Mon, Feb 08, 2021 at 11:34:18AM +0100, Peter Zijlstra wrote: > On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote: > > > Silently delete "extern" from prototypes. > > NAK, extern is right. Extern is only necessary for variables.

Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

2021-02-08 Thread Peter Zijlstra
On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote: > 32-bit accesses are shorter than 64-bit accesses on x86_64. > Nothing uses 64-bitness of struct task_struct::state. > > Propagate 32-bitness to other variables and functions. You're saving a handful of bytes, why? > --- a/include

Re: [PATCH 1/5] sched: make struct task_struct::state 32-bit

2021-02-08 Thread Peter Zijlstra
On Sat, Feb 06, 2021 at 06:18:32PM +0300, Alexey Dobriyan wrote: > Silently delete "extern" from prototypes. NAK, extern is right.