Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()

2013-12-14 Thread Zhi Yong Wu
On Sat, Dec 14, 2013 at 7:20 PM, Jeff Liu wrote: > On 12/14 2013 00:32 AM, Christoph Hellwig wrote: >>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp) >>> +{ >>> +if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) >>> +return xfs_get_projid(dp); >>> +else >>> +

Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()

2013-12-14 Thread Jeff Liu
On 12/14 2013 00:32 AM, Christoph Hellwig wrote: >> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp) >> +{ >> +if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) >> +return xfs_get_projid(dp); >> +else >> +return XFS_PROJID_DEFAULT; >> +} > > You could s

Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()

2013-12-13 Thread Christoph Hellwig
> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp) > +{ > + if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT) > + return xfs_get_projid(dp); > + else > + return XFS_PROJID_DEFAULT; > +} You could skip the else here. Otherwise looks good, Reviewed-by: