Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

2007-10-10 Thread Randy Dunlap
[EMAIL PROTECTED] wrote: On Wed, 10 Oct 2007 08:40:31 PDT, Randy Dunlap said: config SECURITY_SELINUX bool "NSA SELinux Support" - depends on SECURITY_NETWORK && AUDIT && NET && INET + depends on SECURITY + select SECURITY_NETWORK + select AUDIT + select N

Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

2007-10-10 Thread Valdis . Kletnieks
On Wed, 10 Oct 2007 08:40:31 PDT, Randy Dunlap said: > >>> config SECURITY_SELINUX > >>> bool "NSA SELinux Support" > >>> - depends on SECURITY_NETWORK && AUDIT && NET && INET > >>> + depends on SECURITY > >>> + select SECURITY_NETWORK > >>> + select AUDIT > >>> + select NET > >>> + select INET

Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

2007-10-10 Thread Randy Dunlap
Stephen Smalley wrote: On Tue, 2007-10-09 at 16:28 -0700, Randy Dunlap wrote: On Wed, 10 Oct 2007 09:19:55 +1000 (EST) James Morris wrote: From: Eric Paris <[EMAIL PROTECTED]> Changes the security/selinux/Kconfig to use select instead of depends for most of the SELinux requirements. This all

Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

2007-10-10 Thread Stephen Smalley
On Tue, 2007-10-09 at 16:28 -0700, Randy Dunlap wrote: > On Wed, 10 Oct 2007 09:19:55 +1000 (EST) James Morris wrote: > > > From: Eric Paris <[EMAIL PROTECTED]> > > > > Changes the security/selinux/Kconfig to use select instead of depends > > for most of the SELinux requirements. This allows the

Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

2007-10-09 Thread Randy Dunlap
On Wed, 10 Oct 2007 09:50:49 +1000 (EST) James Morris wrote: > On Tue, 9 Oct 2007, Randy Dunlap wrote: > > > I doth protest. Enabling the entire NET subsystem thru a hidden > > select is awful. Select should be used (sparingly) to enable > > library code only. If someone wants NET enabled, the

Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

2007-10-09 Thread James Morris
On Tue, 9 Oct 2007, Randy Dunlap wrote: > I doth protest. Enabling the entire NET subsystem thru a hidden > select is awful. Select should be used (sparingly) to enable > library code only. If someone wants NET enabled, they should > enable it overtly, not covertly. Ok, fair enough. I've drop

Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends

2007-10-09 Thread Randy Dunlap
On Wed, 10 Oct 2007 09:19:55 +1000 (EST) James Morris wrote: > From: Eric Paris <[EMAIL PROTECTED]> > > Changes the security/selinux/Kconfig to use select instead of depends > for most of the SELinux requirements. This allows the SELinux option to > show up when people do a make config without a