Re: [PATCH 1/6] x86: fix duplicated X86_BUG(9) macro

2016-07-03 Thread Borislav Petkov
On Sun, Jul 03, 2016 at 07:36:30AM -0700, Andy Lutomirski wrote: > Dunno. ESPFIX was broken under KVM for years and no one notices. Ah, so this really was the case already. :-\ > We could do that, too, I guess. But the current solution is only two > extra lines of code. We could reorder the th

Re: [PATCH 1/6] x86: fix duplicated X86_BUG(9) macro

2016-07-03 Thread Andy Lutomirski
On Jul 1, 2016 9:47 AM, "Borislav Petkov" wrote: > > On Fri, Jul 01, 2016 at 09:30:37AM -0700, Andy Lutomirski wrote: > > I put the ifdef there to prevent anyone from accidentally using it in > > a 64-bit code path, not to save a bit. We could put in the middle of > > the list to make the mistake

Re: [PATCH 1/6] x86: fix duplicated X86_BUG(9) macro

2016-07-01 Thread Borislav Petkov
On Fri, Jul 01, 2016 at 09:30:37AM -0700, Andy Lutomirski wrote: > I put the ifdef there to prevent anyone from accidentally using it in > a 64-bit code path, not to save a bit. We could put in the middle of > the list to make the mistake much less likely to be repeated, I > suppose. Well, if som

Re: [PATCH 1/6] x86: fix duplicated X86_BUG(9) macro

2016-07-01 Thread Andy Lutomirski
On Jul 1, 2016 2:23 AM, "Borislav Petkov" wrote: > > On Thu, Jun 30, 2016 at 05:12:10PM -0700, Dave Hansen wrote: > > > > From: Dave Hansen > > > > epufeatures.h currently defines X86_BUG(9) twice on 32-bit: > > > > #define X86_BUG_NULL_SEGX86_BUG(9) /* Nulling a selector > > prese

Re: [PATCH 1/6] x86: fix duplicated X86_BUG(9) macro

2016-07-01 Thread Borislav Petkov
On Thu, Jun 30, 2016 at 05:12:10PM -0700, Dave Hansen wrote: > > From: Dave Hansen > > epufeatures.h currently defines X86_BUG(9) twice on 32-bit: > > #define X86_BUG_NULL_SEGX86_BUG(9) /* Nulling a selector > preserves the base */ > ... > #ifdef CONFIG_X86_32 >