Re: [PATCH 1/7] uprobes: Move alloc_page() from xol_add_vma() to xol_alloc_area()

2013-01-09 Thread Srikar Dronamraju
* Oleg Nesterov [2013-01-08 18:58:22]: > On 01/08, Srikar Dronamraju wrote: > > > > (One simple check below) > > > > Acked-by: Srikar Dronamraju > > Thanks, > > > > @@ -1072,11 +1064,8 @@ static int xol_add_vma(struct xol_area *area) > > > smp_wmb(); /* pairs with get_xol_area() */ > >

Re: [PATCH 1/7] uprobes: Move alloc_page() from xol_add_vma() to xol_alloc_area()

2013-01-08 Thread Oleg Nesterov
On 01/08, Srikar Dronamraju wrote: > > (One simple check below) > > Acked-by: Srikar Dronamraju Thanks, > > @@ -1072,11 +1064,8 @@ static int xol_add_vma(struct xol_area *area) > > smp_wmb(); /* pairs with get_xol_area() */ > > mm->uprobes_state.xol_area = area; > > ret = 0; > >

Re: [PATCH 1/7] uprobes: Move alloc_page() from xol_add_vma() to xol_alloc_area()

2013-01-08 Thread Srikar Dronamraju
* Oleg Nesterov [2012-12-31 18:52:12]: > Move alloc_page() from xol_add_vma() to xol_alloc_area() to cleanup > the code. This separates the memory allocations and consolidates the > -EALREADY cleanups and the error handling. > > Signed-off-by: Oleg Nesterov (One simple check below) Acked-by:

Re: [PATCH 1/7] uprobes: Move alloc_page() from xol_add_vma() to xol_alloc_area()

2013-01-07 Thread Oleg Nesterov
On 01/07, Anton Arapov wrote: > > On Mon, Dec 31, 2012 at 06:52:12PM +0100, Oleg Nesterov wrote: > > - goto fail; > > + goto free_area; > > + > > + area->page = area->page = alloc_page(GFP_HIGHUSER); > > fyi: didn't review this patch set yet, just caught the string above. ;)

Re: [PATCH 1/7] uprobes: Move alloc_page() from xol_add_vma() to xol_alloc_area()

2013-01-07 Thread Anton Arapov
On Mon, Dec 31, 2012 at 06:52:12PM +0100, Oleg Nesterov wrote: > Move alloc_page() from xol_add_vma() to xol_alloc_area() to cleanup > the code. This separates the memory allocations and consolidates the > -EALREADY cleanups and the error handling. > > Signed-off-by: Oleg Nesterov > --- > kernel