Re: [PATCH 1/9] staging: ion: tidy up a bit

2014-05-27 Thread John Stultz
On Tue, May 27, 2014 at 11:52 AM, Greg Kroah-Hartman wrote: > On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: >> For aesthetics and readability, rename goto labels, remove >> useless code lines, and clarify function return type. >> >> Signed-off-by: Heesub Shin >> --- >> drivers/sta

Re: [PATCH 1/9] staging: ion: tidy up a bit

2014-05-27 Thread Greg Kroah-Hartman
On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: > For aesthetics and readability, rename goto labels, remove > useless code lines, and clarify function return type. > > Signed-off-by: Heesub Shin > --- > drivers/staging/android/ion/ion_page_pool.c | 2 +- > drivers/staging/androi

Re: [PATCH 1/9] staging: ion: tidy up a bit

2014-05-27 Thread Dan Carpenter
On Tue, May 27, 2014 at 09:58:18AM +0900, Heesub Shin wrote: > Hello Carpenter, > > On 05/26/2014 07:36 PM, Dan Carpenter wrote: > >On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: > >>@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct > >>ion_system_heap *hea

Re: [PATCH 1/9] staging: ion: tidy up a bit

2014-05-26 Thread Heesub Shin
Hello Carpenter, On 05/26/2014 07:36 PM, Dan Carpenter wrote: On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: @@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap, info->page = page; info->order = orders

Re: [PATCH 1/9] staging: ion: tidy up a bit

2014-05-26 Thread Dan Carpenter
On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote: > @@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct > ion_system_heap *heap, > > info->page = page; > info->order = orders[i]; > - INIT_LIST_HEAD(&info->list); >