Re: [PATCH 10/13] xfs: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-10 Thread Dave Chinner
On Wed, Jul 10, 2013 at 12:00:57PM +0200, Yann Droneaud wrote: > Hi, > > Le 09.07.2013 22:53, Ben Myers a écrit : > >On Mon, Jul 08, 2013 at 05:41:33PM -0500, Ben Myers wrote: > >>On Tue, Jul 02, 2013 at 06:39:34PM +0200, Yann Droneaud wrote: > > >>> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_i

Re: [PATCH 10/13] xfs: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-10 Thread Yann Droneaud
Hi, Le 09.07.2013 22:53, Ben Myers a écrit : On Mon, Jul 08, 2013 at 05:41:33PM -0500, Ben Myers wrote: On Tue, Jul 02, 2013 at 06:39:34PM +0200, Yann Droneaud wrote: > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c > index 5e99968..dc5b659 100644 > --- a/fs/xfs/xfs_ioctl.c > +++ b/fs/

Re: [PATCH 10/13] xfs: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-09 Thread Ben Myers
Yann, On Mon, Jul 08, 2013 at 05:41:33PM -0500, Ben Myers wrote: > On Tue, Jul 02, 2013 at 06:39:34PM +0200, Yann Droneaud wrote: > > Macro get_unused_fd() is used to allocate a file descriptor with > > default flags. Those default flags (0) can be "unsafe": > > O_CLOEXEC must be used by default t

Re: [PATCH 10/13] xfs: use get_unused_fd_flags(0) instead of get_unused_fd()

2013-07-08 Thread Ben Myers
On Tue, Jul 02, 2013 at 06:39:34PM +0200, Yann Droneaud wrote: > Macro get_unused_fd() is used to allocate a file descriptor with > default flags. Those default flags (0) can be "unsafe": > O_CLOEXEC must be used by default to not leak file descriptor > across exec(). > > Instead of macro get_unus