Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-19 Thread Namhyung Kim
Hi Steve, On Thu, 19 Dec 2013 09:18:30 -0500, Steven Rostedt wrote: > On Thu, 19 Dec 2013 16:34:09 +0900 > Namhyung Kim wrote: > >> Hi Steve, >> >> On Wed, 18 Dec 2013 15:23:38 -0500, Steven Rostedt wrote: >> > On Mon, 16 Dec 2013 13:32:09 +0900 >> > Namhyung Kim wrote: >> > >> >> index 5395d37

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-19 Thread Steven Rostedt
On Thu, 19 Dec 2013 16:34:09 +0900 Namhyung Kim wrote: > Hi Steve, > > On Wed, 18 Dec 2013 15:23:38 -0500, Steven Rostedt wrote: > > On Mon, 16 Dec 2013 13:32:09 +0900 > > Namhyung Kim wrote: > > > >> index 5395d37e5e72..adc9ac70fd3c 100644 > >> --- a/kernel/trace/trace_uprobe.c > >> +++ b/kern

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-19 Thread Namhyung Kim
Hi Oleg, On Wed, 18 Dec 2013 21:34:24 +0100, Oleg Nesterov wrote: > On 12/18, Steven Rostedt wrote: >> >> On Tue, 17 Dec 2013 09:16:37 +0900 >> Namhyung Kim wrote: >> >> > Hi Steve, >> > >> > Would you please review this and consider merging it? It seems there's >> > no more remaining issue and

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-19 Thread Namhyung Kim
On Wed, 18 Dec 2013 15:25:53 -0500, Steven Rostedt wrote: > I don't have test code for uprobes, and I have minimal test code for > kprobes. How has this been tested? Basically I tested it with a very simple example code like in the description of this patchset and the code in the link below - note

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-18 Thread Namhyung Kim
Hi Steve, On Wed, 18 Dec 2013 15:23:38 -0500, Steven Rostedt wrote: > On Mon, 16 Dec 2013 13:32:09 +0900 > Namhyung Kim wrote: > >> index 5395d37e5e72..adc9ac70fd3c 100644 >> --- a/kernel/trace/trace_uprobe.c >> +++ b/kernel/trace/trace_uprobe.c >> @@ -115,6 +115,14 @@ DEFINE_BASIC_FETCH_FUNCS(st

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-18 Thread Oleg Nesterov
On 12/18, Steven Rostedt wrote: > > On Tue, 17 Dec 2013 09:16:37 +0900 > Namhyung Kim wrote: > > > Hi Steve, > > > > Would you please review this and consider merging it? It seems there's > > no more remaining issue and we want to make a progress on it. :) > > > > Oleg, Srikar, it'd be great if y

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-18 Thread Steven Rostedt
On Tue, 17 Dec 2013 09:16:37 +0900 Namhyung Kim wrote: > Hi Steve, > > Would you please review this and consider merging it? It seems there's > no more remaining issue and we want to make a progress on it. :) > > Oleg, Srikar, it'd be great if you could confirm it though. > I'd feel better i

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-18 Thread Steven Rostedt
On Mon, 16 Dec 2013 13:32:09 +0900 Namhyung Kim wrote: > index 5395d37e5e72..adc9ac70fd3c 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -115,6 +115,14 @@ DEFINE_BASIC_FETCH_FUNCS(stack) > #define fetch_stack_string_size NULL > > > +/* uprobes don't

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-16 Thread Namhyung Kim
Hi Steve, Would you please review this and consider merging it? It seems there's no more remaining issue and we want to make a progress on it. :) Oleg, Srikar, it'd be great if you could confirm it though. Thanks, Namhyung On Mon, 16 Dec 2013 17:40:23 +0900, Namhyung Kim wrote: > Hi Masami, >

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-16 Thread Namhyung Kim
Hi Masami, On Mon, 16 Dec 2013 17:23:25 +0900, Masami Hiramatsu wrote: > (2013/12/16 13:32), Namhyung Kim wrote: >> From: Namhyung Kim >> >> Move existing functions to trace_kprobe.c and add NULL entries to the >> uprobes fetch type table. I don't make them static since some generic >> routines

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-16 Thread Masami Hiramatsu
(2013/12/16 13:32), Namhyung Kim wrote: > From: Namhyung Kim > > Move existing functions to trace_kprobe.c and add NULL entries to the > uprobes fetch type table. I don't make them static since some generic > routines like update/free_XXX_fetch_param() require pointers to the > functions. > > C

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-10 Thread Masami Hiramatsu
(2013/12/11 10:05), Namhyung Kim wrote: > Hi Masami, > > On Tue, 10 Dec 2013 19:12:36 +0900, Masami Hiramatsu wrote: >> (2013/12/09 15:19), Namhyung Kim wrote: >> >>> diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h >>> index 23b2d83ee5fb..d327a1c21f4b 100644 >>> --- a/kernel/t

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-10 Thread Namhyung Kim
Hi Masami, On Tue, 10 Dec 2013 19:12:36 +0900, Masami Hiramatsu wrote: > (2013/12/09 15:19), Namhyung Kim wrote: > >> diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h >> index 23b2d83ee5fb..d327a1c21f4b 100644 >> --- a/kernel/trace/trace_probe.h >> +++ b/kernel/trace/trace_prob

Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes

2013-12-10 Thread Masami Hiramatsu
(2013/12/09 15:19), Namhyung Kim wrote: > diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h > index 23b2d83ee5fb..d327a1c21f4b 100644 > --- a/kernel/trace/trace_probe.h > +++ b/kernel/trace/trace_probe.h > @@ -239,6 +239,30 @@ ASSIGN_FETCH_FUNC(bitfield, ftype),