On Tue, Oct 06, 2020 at 03:33:21PM -0700, Ben Gardon wrote:
> On Wed, Sep 30, 2020 at 9:37 AM Sean Christopherson
> wrote:
> >
> > On Fri, Sep 25, 2020 at 02:22:50PM -0700, Ben Gardon wrote:
> > > @@ -4113,8 +4088,9 @@ static int direct_page_fault(struct kvm_vcpu *vcpu,
> > > gpa_t gpa, u32 error
On Wed, Sep 30, 2020 at 10:38 AM Paolo Bonzini wrote:
>
> On 30/09/20 18:37, Sean Christopherson wrote:
> >> +ret = page_fault_handle_target_level(vcpu, write, map_writable,
> >> + as_id, &iter, pfn, prefault);
> >> +
> >> +/* If emulating, flush thi
On Wed, Sep 30, 2020 at 9:37 AM Sean Christopherson
wrote:
>
> On Fri, Sep 25, 2020 at 02:22:50PM -0700, Ben Gardon wrote:
> > @@ -4113,8 +4088,9 @@ static int direct_page_fault(struct kvm_vcpu *vcpu,
> > gpa_t gpa, u32 error_code,
> > if (page_fault_handle_page_track(vcpu, error_code, gfn)
On 30/09/20 18:37, Sean Christopherson wrote:
>> +ret = page_fault_handle_target_level(vcpu, write, map_writable,
>> + as_id, &iter, pfn, prefault);
>> +
>> +/* If emulating, flush this vcpu's TLB. */
> Why? It's obvious _what_ the code is doing, the
On 30/09/20 18:37, Sean Christopherson wrote:
>> +
>> +if (WARN_ON(!VALID_PAGE(vcpu->arch.mmu->root_hpa)))
>> +return RET_PF_RETRY;
> I feel like we should kill off these silly WARNs in the existing code instead
> of adding more. If they actually fired, I'm pretty sure that they wo
On Fri, Sep 25, 2020 at 02:22:50PM -0700, Ben Gardon wrote:
> @@ -4113,8 +4088,9 @@ static int direct_page_fault(struct kvm_vcpu *vcpu,
> gpa_t gpa, u32 error_code,
> if (page_fault_handle_page_track(vcpu, error_code, gfn))
> return RET_PF_EMULATE;
>
> - if (fast_page_fau
On 25/09/20 23:22, Ben Gardon wrote:
>
> -static bool is_nx_huge_page_enabled(void)
> +bool is_nx_huge_page_enabled(void)
> {
> return READ_ONCE(nx_huge_pages);
> }
> @@ -381,7 +361,7 @@ static inline u64 spte_shadow_dirty_mask(u64 spte)
> return spte_ad_enabled(spte) ? shadow_dirty
7 matches
Mail list logo
