Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-08 Thread Sachin Kamat
On 8 October 2013 13:36, Linus Walleij wrote: > On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat wrote: > >> The data structure of_match_ptr() protects is always compiled in. >> Hence of_match_ptr() is not needed. >> >> Signed-off-by: Sachin Kamat >> Cc: Viresh Kumar > > I have applied this as wel

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-08 Thread Linus Walleij
On Sat, Sep 28, 2013 at 2:08 PM, Sachin Kamat wrote: > The data structure of_match_ptr() protects is always compiled in. > Hence of_match_ptr() is not needed. > > Signed-off-by: Sachin Kamat > Cc: Viresh Kumar I have applied this as well, and after that I squashed all 11 commits into one. I t

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Sachin Kamat
On 3 October 2013 12:42, Viresh Kumar wrote: > On 3 October 2013 12:40, Sachin Kamat wrote: >> Do you really want a new one. If so, please let me know how you would >> like this to be re-worded. I have already used this for others and >> thought it was clear enough :) > > Ahh.. misread your subje

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Viresh Kumar
On 3 October 2013 12:40, Sachin Kamat wrote: > Do you really want a new one. If so, please let me know how you would > like this to be re-worded. I have already used this for others and > thought it was clear enough :) Ahh.. misread your subject and then your reply :).. -- To unsubscribe from thi

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Viresh Kumar
On 28 September 2013 17:38, Sachin Kamat wrote: > The data structure of_match_ptr() protects is always compiled in. > Hence of_match_ptr() is not needed. > > Signed-off-by: Sachin Kamat > Cc: Viresh Kumar > --- > drivers/pinctrl/spear/pinctrl-plgpio.c |2 +- > 1 file changed, 1 insertion(+)

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Sachin Kamat
On 3 October 2013 12:37, Viresh Kumar wrote: > On 3 October 2013 12:36, Sachin Kamat wrote: >> On 3 October 2013 10:07, Viresh Kumar wrote: >>> On 28 September 2013 17:38, Sachin Kamat wrote: > Yeah I will Ack this.. but was waiting for your next version with fixed log. > :) Do you really wa

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Viresh Kumar
On 3 October 2013 12:36, Sachin Kamat wrote: > On 3 October 2013 10:07, Viresh Kumar wrote: >> On 28 September 2013 17:38, Sachin Kamat wrote: >>> The data structure of_match_ptr() protects is always compiled in. >> >> of_match_ptr() isn't a data structure.. > > Yes you are right. of_match_ptr()

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-03 Thread Sachin Kamat
On 3 October 2013 10:07, Viresh Kumar wrote: > On 28 September 2013 17:38, Sachin Kamat wrote: >> The data structure of_match_ptr() protects is always compiled in. > > of_match_ptr() isn't a data structure.. Yes you are right. of_match_ptr() is a macro. The data structure here refers to its argu

Re: [PATCH 11/11] pinctrl: plgpio: Remove redundant of_match_ptr

2013-10-02 Thread Viresh Kumar
On 28 September 2013 17:38, Sachin Kamat wrote: > The data structure of_match_ptr() protects is always compiled in. of_match_ptr() isn't a data structure.. And also what does "protects" mean here? > Hence of_match_ptr() is not needed. > > Signed-off-by: Sachin Kamat > Cc: Viresh Kumar > --- >