Re: [PATCH 11/12] IPMI: Fix BT long busy

2006-12-08 Thread Andrew Morton
On Fri, 08 Dec 2006 06:03:59 -0700 Rocky Craig <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > >In fact, please don't write macros. > > > > > I see them all over the place (i.e., EXPORT_SYMBOL) so the request > is a little confusing to me... It's a general principle. Sometimes they're u

Re: [PATCH 11/12] IPMI: Fix BT long busy

2006-12-08 Thread Rocky Craig
Andrew Morton wrote: In fact, please don't write macros. I see them all over the place (i.e., EXPORT_SYMBOL) so the request is a little confusing to me... Please don't write macros which require that the caller have a particular local variable of a particular name. I could understand

Re: [PATCH 11/12] IPMI: Fix BT long busy

2006-12-03 Thread Andrew Morton
On Fri, 1 Dec 2006 22:39:21 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > > The IPMI BT subdriver has been patched to survive "long busy" > timeouts seen during firmware upgrades and resets. The patch > never returns the HOSED state, synthesizes response messages with > meaningful completion