Re: [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible

2019-03-24 Thread Masami Hiramatsu
On Sat, 23 Mar 2019 07:35:18 -0700 Andi Kleen wrote: > On Sat, Mar 23, 2019 at 06:45:21PM +0900, Masami Hiramatsu wrote: > > On Thu, 21 Mar 2019 15:00:03 -0700 > > Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > This function is referenced from assembler, so in LTO > > > it needs to

Re: [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible

2019-03-23 Thread Andi Kleen
On Sat, Mar 23, 2019 at 06:45:21PM +0900, Masami Hiramatsu wrote: > On Thu, 21 Mar 2019 15:00:03 -0700 > Andi Kleen wrote: > > > From: Andi Kleen > > > > This function is referenced from assembler, so in LTO > > it needs to be global and visible to not be optimized away. > > > > I got it. >

Re: [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible

2019-03-23 Thread Masami Hiramatsu
On Thu, 21 Mar 2019 15:00:03 -0700 Andi Kleen wrote: > From: Andi Kleen > > This function is referenced from assembler, so in LTO > it needs to be global and visible to not be optimized away. > I got it. Acked-by: Masami Hiramatsu Andi, out of curiousity, that is not only for x86, but does