Re: [PATCH 12/12] cfq-iosched: add hierarchical cfq_group statistics

2012-12-18 Thread Vivek Goyal
On Tue, Dec 18, 2012 at 11:21:55AM -0800, Tejun Heo wrote: > On Tue, Dec 18, 2012 at 02:18:54PM -0500, Vivek Goyal wrote: > > > Yeah, hmmm, maybe we should add another set of counters to carry stats > > > from dead ones? Avoiding hierarchical accounting overhead in hot path > > > while remembering

Re: [PATCH 12/12] cfq-iosched: add hierarchical cfq_group statistics

2012-12-18 Thread Tejun Heo
On Tue, Dec 18, 2012 at 02:18:54PM -0500, Vivek Goyal wrote: > > Yeah, hmmm, maybe we should add another set of counters to carry stats > > from dead ones? Avoiding hierarchical accounting overhead in hot path > > while remembering by-gones shouldn't be that hard. Will work on that. > > So are y

Re: [PATCH 12/12] cfq-iosched: add hierarchical cfq_group statistics

2012-12-18 Thread Vivek Goyal
On Tue, Dec 18, 2012 at 11:14:25AM -0800, Tejun Heo wrote: > Hello, Vivek. > > On Tue, Dec 18, 2012 at 02:11:17PM -0500, Vivek Goyal wrote: > > All these stats needs to be mentioned in blkio-controller.txt file to > > keep that file uptodate. > > > > I think it also needs another word about natu

Re: [PATCH 12/12] cfq-iosched: add hierarchical cfq_group statistics

2012-12-18 Thread Tejun Heo
Hello, Vivek. On Tue, Dec 18, 2012 at 02:11:17PM -0500, Vivek Goyal wrote: > All these stats needs to be mentioned in blkio-controller.txt file to > keep that file uptodate. > > I think it also needs another word about nature of hierarchical stats. > That is they represent current view of the sy

Re: [PATCH 12/12] cfq-iosched: add hierarchical cfq_group statistics

2012-12-18 Thread Vivek Goyal
On Fri, Dec 14, 2012 at 02:41:25PM -0800, Tejun Heo wrote: > Unfortunately, at this point, there's no way to make the existing > statistics hierarchical without creating nasty surprises for the > existing users. Just create recursive counterpart of the existing > stats. > Hi Tejun, All these st