Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-24 Thread David Woodhouse
On Fri, 2017-03-24 at 17:16 +0100, Arnd Bergmann wrote: > > Something alone these lines, to replace your patch 17/17 and the > one that turns on HAVE_PCI_MMAP for arm64. No, I think that won't build because you don't have a pci_mmap_page_range() function. And you didn't define ARCH_GENERIC_PCI_MM

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-24 Thread David Woodhouse
On Fri, 2017-03-24 at 17:13 +0100, Arnd Bergmann wrote: > > I'd still prefer this to be a whitelist of the existing architectures using > PCI > MMAP in procfs, there is really no reason for arm64 to be special, the > one thing we want to control here is whether new architectures (including > arm6

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-24 Thread Arnd Bergmann
On Wed, Mar 22, 2017 at 2:25 PM, David Woodhouse wrote: > From: David Woodhouse > > Signed-off-by: David Woodhouse > --- > drivers/pci/proc.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c > index 2d9cfa4..a940f4b 100644 > --- a/drivers/pci

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-24 Thread Arnd Bergmann
On Fri, Mar 24, 2017 at 5:13 PM, Arnd Bergmann wrote: > On Wed, Mar 22, 2017 at 2:25 PM, David Woodhouse wrote: >> From: David Woodhouse >> >> Signed-off-by: David Woodhouse >> --- >> drivers/pci/proc.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/pci/proc.c b/drive

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-22 Thread Sinan Kaya
On 3/22/2017 10:18 AM, Will Deacon wrote: > On Wed, Mar 22, 2017 at 10:15:04AM -0400, Sinan Kaya wrote: >> On 3/22/2017 10:04 AM, David Woodhouse wrote: >>> On Wed, 2017-03-22 at 09:54 -0400, Sinan Kaya wrote: On 3/22/2017 9:25 AM, David Woodhouse wrote: > > > +#ifdef __aarch64__

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-22 Thread Will Deacon
On Wed, Mar 22, 2017 at 10:15:04AM -0400, Sinan Kaya wrote: > On 3/22/2017 10:04 AM, David Woodhouse wrote: > > On Wed, 2017-03-22 at 09:54 -0400, Sinan Kaya wrote: > >> On 3/22/2017 9:25 AM, David Woodhouse wrote: > >>> > >>> > >>> +#ifdef __aarch64__ > >>> +/* ARM64 wants to be special and not

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-22 Thread Sinan Kaya
On 3/22/2017 10:04 AM, David Woodhouse wrote: > On Wed, 2017-03-22 at 09:54 -0400, Sinan Kaya wrote: >> On 3/22/2017 9:25 AM, David Woodhouse wrote: >>> >>> >>> +#ifdef __aarch64__ >>> +/* ARM64 wants to be special and not expose this through /proc >>> like everyone else */ >>> +#undef HAVE_PCI_M

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-22 Thread Sinan Kaya
On 3/22/2017 9:25 AM, David Woodhouse wrote: > > +#ifdef __aarch64__ > +/* ARM64 wants to be special and not expose this through /proc like everyone > else */ > +#undef HAVE_PCI_MMAP > +#endif > + Where is this ARM64 special requirement coming from? -- Sinan Kaya Qualcomm Datacenter Technolog

Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs

2017-03-22 Thread David Woodhouse
On Wed, 2017-03-22 at 09:54 -0400, Sinan Kaya wrote: > On 3/22/2017 9:25 AM, David Woodhouse wrote: > > > >   > > +#ifdef __aarch64__ > > +/* ARM64 wants to be special and not expose this through /proc > > like everyone else */ > > +#undef HAVE_PCI_MMAP > > +#endif > > + > Where is this ARM64 spec