Re: [PATCH 19/23] truncate: support huge pages

2013-08-09 Thread Kirill A. Shutemov
Dave Hansen wrote: > On 08/03/2013 07:17 PM, Kirill A. Shutemov wrote: > > If a huge page is only partly in the range we zero out the part, > > exactly like we do for partial small pages. > > What's the logic behind this behaviour? Seems like the kind of place > that we would really want to be sp

Re: [PATCH 19/23] truncate: support huge pages

2013-08-06 Thread Dave Hansen
On 08/03/2013 07:17 PM, Kirill A. Shutemov wrote: > If a huge page is only partly in the range we zero out the part, > exactly like we do for partial small pages. What's the logic behind this behaviour? Seems like the kind of place that we would really want to be splitting pages. > + if (par

Re: [PATCH 19/23] truncate: support huge pages

2013-08-06 Thread Kirill A. Shutemov
On Tue, Aug 06, 2013 at 01:23:48PM -0700, Dave Hansen wrote: > On 08/03/2013 07:17 PM, Kirill A. Shutemov wrote: > > + if (PageTransTailCache(page)) { > > + /* part of already handled huge page */ > > + if (!page->mapping) > > +

Re: [PATCH 19/23] truncate: support huge pages

2013-08-06 Thread Dave Hansen
On 08/03/2013 07:17 PM, Kirill A. Shutemov wrote: > + if (PageTransTailCache(page)) { > + /* part of already handled huge page */ > + if (!page->mapping) > + continue; > +

Re: [PATCH 19/23] truncate: support huge pages

2013-08-05 Thread Jan Kara
On Sun 04-08-13 05:17:21, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > truncate_inode_pages_range() drops whole huge page at once if it's fully > inside the range. > > If a huge page is only partly in the range we zero out the part, > exactly like we do for partial small pages. >