Re: [PATCH 2/11] Sched clock paravirt op

2007-02-06 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Scheduled (or available) time and real time are good notions. Stolen time is debatable. But TSC is basically just always wrong. That's why I don't want to overload the rdtsc op

Re: [PATCH 2/11] Sched clock paravirt op

2007-02-06 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: > Jeremy Fitzhardinge wrote: >> Zachary Amsden wrote: >> >>> Scheduled (or available) time and real time are good notions. Stolen >>> time is debatable. But TSC is basically just always wrong. That's >>> why I don't want to overload the rdtsc operation. >> Well, in t

Re: [PATCH 2/11] Sched clock paravirt op

2007-02-06 Thread Zachary Amsden
Jeremy Fitzhardinge wrote: Zachary Amsden wrote: Scheduled (or available) time and real time are good notions. Stolen time is debatable. But TSC is basically just always wrong. That's why I don't want to overload the rdtsc operation. Well, in the Xen case it is actually guaranteed t

Re: [PATCH 2/11] Sched clock paravirt op

2007-02-06 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: > Scheduled (or available) time and real time are good notions. Stolen > time is debatable. But TSC is basically just always wrong. That's > why I don't want to overload the rdtsc operation. Well, in the Xen case it is actually guaranteed to be correct and useful as real t

Re: [PATCH 2/11] Sched clock paravirt op

2007-02-06 Thread Zachary Amsden
Andi Kleen wrote: .write_msr = native_write_msr, .read_tsc = native_read_tsc, .read_pmc = native_read_pmc, + .get_scheduled_cycles = native_read_tsc, + .get_cpu_khz = native_calculate_cpu_khz, .load_tr_desc = native_load_tr_desc, Description missin

Re: [PATCH 2/11] Sched clock paravirt op

2007-02-06 Thread Andi Kleen
> .write_msr = native_write_msr, > .read_tsc = native_read_tsc, > .read_pmc = native_read_pmc, > + .get_scheduled_cycles = native_read_tsc, > + .get_cpu_khz = native_calculate_cpu_khz, > .load_tr_desc = native_load_tr_desc, Description missing? Please write at lea

Re: [PATCH 2/11] Sched clock paravirt op

2007-02-05 Thread Zachary Amsden
Zachary Amsden wrote: #include "mach_timer.h" @@ -102,9 +103,6 @@ unsigned long long sched_clock(void) { unsigned long long this_offset; - if (unlikely(custom_sched_clock)) - return (*custom_sched_clock)(); - /* * Fall back to jiffies if there's no